third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp - Issue 1577243002: setRangeText shouldn't dispatch 'search' event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 1577243002: setRangeText shouldn't dispatch 'search' event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

index 55ef12825dd0ab94044637432708d7dfb80cf6c5..1110e6f8d7f0714b0d52a6bd590d26a07ba1e740 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

@@ -235,8 +235,7 @@ void HTMLTextFormControlElement::setRangeText(const String& replacement, unsigne

else

text.insert(replacement, start);

- setInnerEditorValue(text);

- subtreeHasChanged();

+ setValue(text, TextFieldEventBehavior::DispatchNoEvent);

if (selectionMode == "select") {

newSelectionStart = start;

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h ('k') | no next file » | no next file with comments »