chrome/test/chromedriver/chrome/navigation_tracker.h - Issue 15772009: [chromedriver] Fix race where we might not wait for page load after navigating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/navigation_tracker.h

Issue 15772009: [chromedriver] Fix race where we might not wait for page load after navigating. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_event_listener.cc ('k') | chrome/test/chromedriver/chrome/navigation_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/navigation_tracker.h

diff --git a/chrome/test/chromedriver/chrome/navigation_tracker.h b/chrome/test/chromedriver/chrome/navigation_tracker.h

index 45c8b9861ed1b86545c1c333cad87265acc3e85c..cd162066d7b1195c50b6ca26841fc3e8d50c2790 100644

--- a/chrome/test/chromedriver/chrome/navigation_tracker.h

+++ b/chrome/test/chromedriver/chrome/navigation_tracker.h

@@ -42,6 +42,8 @@ class NavigationTracker : public DevToolsEventListener {

virtual void OnEvent(DevToolsClient* client,

const std::string& method,

const base::DictionaryValue& params) OVERRIDE;

+ virtual Status OnCommandSuccess(DevToolsClient* client,

+ const std::string& method) OVERRIDE;

private:

DevToolsClient* client_;