Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: chrome/test/chromedriver/chrome/navigation_tracker.cc

Issue 15772009: [chromedriver] Fix race where we might not wait for page load after navigating. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/navigation_tracker.cc
diff --git a/chrome/test/chromedriver/chrome/navigation_tracker.cc b/chrome/test/chromedriver/chrome/navigation_tracker.cc
index cd04f819dcd82ff21cad30f63bc51b8845943e52..509b318c44a5c2a9400c4bf04e65cd41b79fdfc9 100644
--- a/chrome/test/chromedriver/chrome/navigation_tracker.cc
+++ b/chrome/test/chromedriver/chrome/navigation_tracker.cc
@@ -126,3 +126,10 @@ void NavigationTracker::OnEvent(DevToolsClient* client,
scheduled_frame_set_.clear();
}
}
+
+Status NavigationTracker::OnCommandSuccess(DevToolsClient* client,
+ const std::string& method) {
+ if (method == "Page.navigate")
+ loading_state_ = kLoading;
+ return Status(kOk);
+}
« no previous file with comments | « chrome/test/chromedriver/chrome/navigation_tracker.h ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698