Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 15772003: Disk Cache: Make Stats independent of the backend implementation. (Closed)

Created:
7 years, 7 months ago by rvargas (doing something else)
Modified:
7 years, 7 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Disk Cache: Make Stats independent of the backend implementation. Stats is still dependent on block files, but now they don't call back into BackendImpl BUG=241277 TEST=none R=gavinp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201943

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -75 lines) Patch
M net/disk_cache/addr.h View 1 chunk +5 lines, -0 lines 2 comments Download
M net/disk_cache/backend_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 4 chunks +59 lines, -3 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/disk_cache/stats.h View 5 chunks +12 lines, -7 lines 2 comments Download
M net/disk_cache/stats.cc View 4 chunks +36 lines, -63 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
rvargas (doing something else)
7 years, 7 months ago (2013-05-22 21:27:54 UTC) #1
gavinp
lgtm, only nits which you can take or leave. https://codereview.chromium.org/15772003/diff/1/net/disk_cache/addr.h File net/disk_cache/addr.h (right): https://codereview.chromium.org/15772003/diff/1/net/disk_cache/addr.h#newcode130 net/disk_cache/addr.h:130: ...
7 years, 7 months ago (2013-05-23 15:32:33 UTC) #2
rvargas (doing something else)
Thanks https://codereview.chromium.org/15772003/diff/1/net/disk_cache/addr.h File net/disk_cache/addr.h (right): https://codereview.chromium.org/15772003/diff/1/net/disk_cache/addr.h#newcode130 net/disk_cache/addr.h:130: static int RequiredBlocks(int size, FileType file_type) { On ...
7 years, 7 months ago (2013-05-23 19:39:42 UTC) #3
rvargas (doing something else)
7 years, 7 months ago (2013-05-24 00:47:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r201943 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698