Change the CompilationInfo::IsCodePreAgingActive() predicate to CompilationInfo::GeneratePreagingPr…

Change the CompilationInfo::IsCodePreAgingActive() predicate to CompilationInfo::GeneratePreagingPrologue() and handle the case of WASM functions, which should not be aged.

R=mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/aacce20038d9faae886d0af75cecfef1adc97b08
Cr-Commit-Position: refs/heads/master@{#33232}

[Michael Starzinger, 2016-01-12 09:43:34]

LGTM.

https://codereview.chromium.org/1577193003/diff/1/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1577193003/diff/1/src/compiler.h#newcode272
src/compiler.h:272: // WASM functions cannot be aged, since they have no
corresponding
As discussed offline: Can we slightly rephrase the comment? Since the reason for
not pre-aging WASM functions is because it doesn't make sense to age/flush WASM
functions, and not that we technically couldn't age them.

[titzer, 2016-01-12 09:54:15]

On 2016/01/12 09:43:34, Michael Starzinger wrote:
> LGTM.
> 
> https://codereview.chromium.org/1577193003/diff/1/src/compiler.h
> File src/compiler.h (right):
> 
> https://codereview.chromium.org/1577193003/diff/1/src/compiler.h#newcode272
> src/compiler.h:272: // WASM functions cannot be aged, since they have no
> corresponding
> As discussed offline: Can we slightly rephrase the comment? Since the reason
for
> not pre-aging WASM functions is because it doesn't make sense to age/flush
WASM
> functions, and not that we technically couldn't age them.

Done.

[titzer, 2016-01-12 09:54:22]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-01-12 09:54:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1577193003/#ps20001
(title: "Comment cleanup.")

[commit-bot: I haz the power, 2016-01-12 09:54:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577193003/20001

[commit-bot: I haz the power, 2016-01-12 10:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 10:05:24]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9659)

[titzer, 2016-01-12 10:10:35]

Description was changed from

==========
Change the CompilationInfo::IsCodePreAgingActive() predicate to
CompilationInfo::GeneratePreagingPrologue() and handle the case of WASM
functions, which should not be aged.

R=mstarzinger@chromium.org
BUG=
==========

to

==========
Change the CompilationInfo::IsCodePreAgingActive() predicate to
CompilationInfo::GeneratePreagingPrologue() and handle the case of WASM
functions, which should not be aged.

R=mstarzinger@chromium.org
BUG=
==========

[titzer, 2016-01-12 10:10:35]

titzer@chromium.org changed reviewers:
+ jarin@chromium.org

[titzer, 2016-01-12 10:11:04]

On 2016/01/12 10:05:24, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9659)

+jarin for src/crankshaft, which I didn't realize I wasn't an OWNER of. Should I
be happy to be free? :-)

[Jarin, 2016-01-12 10:36:57]

crankshaft changes lgtm

[titzer, 2016-01-12 10:38:21]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-01-12 10:38:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577193003/20001

[commit-bot: I haz the power, 2016-01-12 10:48:51]

Description was changed from

==========
Change the CompilationInfo::IsCodePreAgingActive() predicate to
CompilationInfo::GeneratePreagingPrologue() and handle the case of WASM
functions, which should not be aged.

R=mstarzinger@chromium.org
BUG=
==========

to

==========
Change the CompilationInfo::IsCodePreAgingActive() predicate to
CompilationInfo::GeneratePreagingPrologue() and handle the case of WASM
functions, which should not be aged.

R=mstarzinger@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-01-12 10:48:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-12 10:49:38]

Description was changed from

==========
Change the CompilationInfo::IsCodePreAgingActive() predicate to
CompilationInfo::GeneratePreagingPrologue() and handle the case of WASM
functions, which should not be aged.

R=mstarzinger@chromium.org
BUG=
==========

to

==========
Change the CompilationInfo::IsCodePreAgingActive() predicate to
CompilationInfo::GeneratePreagingPrologue() and handle the case of WASM
functions, which should not be aged.

R=mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/aacce20038d9faae886d0af75cecfef1adc97b08
Cr-Commit-Position: refs/heads/master@{#33232}
==========

[commit-bot: I haz the power, 2016-01-12 10:49:39]

Patchset 2 (id:??) landed as
https://crrev.com/aacce20038d9faae886d0af75cecfef1adc97b08
Cr-Commit-Position: refs/heads/master@{#33232}