Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: src/compiler.h

Issue 1577193003: Change the CompilationInfo::IsCodePreAgingActive() predicate to CompilationInfo::GeneratePreagingPr… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comment cleanup. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/arm/code-generator-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index c7b822293c1a8ae685fba6ad605fb1b44ef1d309..8aefe9205a90ca0bfe4059fdafbe2418900810c7 100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -268,10 +268,12 @@ class CompilationInfo {
bool is_first_compile() const { return GetFlag(kFirstCompile); }
- bool IsCodePreAgingActive() const {
- // TODO(bradnelson): Figure out why this breaks wasm.
+ bool GeneratePreagedPrologue() const {
+ // Generate a pre-aged prologue if we are optimizing for size, which
+ // will make code flushing more aggressive. The code for WASM functions
+ // cannot be flushed, so it does not make sense to age them.
return FLAG_optimize_for_size && FLAG_age_code && !will_serialize() &&
- !is_debug() && !FLAG_expose_wasm;
+ !is_debug() && output_code_kind_ != Code::WASM_FUNCTION;
}
void EnsureFeedbackVector();
« no previous file with comments | « no previous file | src/compiler/arm/code-generator-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698