|
|
DescriptionCleanup pkg-config.py
While making a seperate change I noticed this script
could use a re-factor.
- Add --debug/-d flag to output extra information to stderr.
- Move main logic into main() function (makes script more easily testable).
- Add #! line to make script runnable.
Committed: https://crrev.com/688a776fea591ac9b292730e1f8ae708b15cf809
Cr-Commit-Position: refs/heads/master@{#368967}
Patch Set 1 #Patch Set 2 : #
Dependent Patchsets: Messages
Total messages: 22 (11 generated)
Description was changed from ========== Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. BUG= ========== to ========== Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function. - Add #! line to make script runnable. ==========
sbc@chromium.org changed reviewers: + dpranke@chromium.org
Description was changed from ========== Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function. - Add #! line to make script runnable. ========== to ========== Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function (makes script more easily testable). - Add #! line to make script runnable. ==========
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577163002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577163002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sbc@chromium.org changed reviewers: + scottmg@chromium.org
+scottmg (dpranke marked as slow)
lgtm
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577163002/20001
Message was sent while issue was closed.
Description was changed from ========== Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function (makes script more easily testable). - Add #! line to make script runnable. ========== to ========== Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function (makes script more easily testable). - Add #! line to make script runnable. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function (makes script more easily testable). - Add #! line to make script runnable. ========== to ========== Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function (makes script more easily testable). - Add #! line to make script runnable. Committed: https://crrev.com/688a776fea591ac9b292730e1f8ae708b15cf809 Cr-Commit-Position: refs/heads/master@{#368967} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/688a776fea591ac9b292730e1f8ae708b15cf809 Cr-Commit-Position: refs/heads/master@{#368967}
Message was sent while issue was closed.
lgtm |