Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 1577163002: Cleanup pkg-config.py (Closed)

Created:
4 years, 11 months ago by Sam Clegg
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup pkg-config.py While making a seperate change I noticed this script could use a re-factor. - Add --debug/-d flag to output extra information to stderr. - Move main logic into main() function (makes script more easily testable). - Add #! line to make script runnable. Committed: https://crrev.com/688a776fea591ac9b292730e1f8ae708b15cf809 Cr-Commit-Position: refs/heads/master@{#368967}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -98 lines) Patch
M build/config/linux/pkg-config.py View 1 3 chunks +106 lines, -98 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (11 generated)
Sam Clegg
4 years, 11 months ago (2016-01-11 23:59:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577163002/1
4 years, 11 months ago (2016-01-12 00:01:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-12 00:58:49 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577163002/20001
4 years, 11 months ago (2016-01-12 17:52:50 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-12 18:14:23 UTC) #12
Sam Clegg
+scottmg (dpranke marked as slow)
4 years, 11 months ago (2016-01-12 19:33:16 UTC) #14
scottmg
lgtm
4 years, 11 months ago (2016-01-12 19:57:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577163002/20001
4 years, 11 months ago (2016-01-12 20:07:20 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-12 20:13:19 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/688a776fea591ac9b292730e1f8ae708b15cf809 Cr-Commit-Position: refs/heads/master@{#368967}
4 years, 11 months ago (2016-01-12 20:14:28 UTC) #21
Dirk Pranke
4 years, 10 months ago (2016-01-26 01:53:06 UTC) #22
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698