Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default
libdir which makes the build more hermetic and forces the
sysroot to provide all the required .pc files.

Committed: https://crrev.com/4d4a9acde47d5e955c12eb0bf3feaa800c2a6f55
Cr-Commit-Position: refs/heads/master@{#369224}

[Sam Clegg, 2016-01-12 02:14:26]

sbc@chromium.org changed reviewers:
+ dpranke@chromium.org, thestig@chromium.org

[Sam Clegg, 2016-01-12 02:14:57]

Description was changed from

==========
Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
alwasy fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default libdir
which makes the build more hermetic and forces the sysroot
to provide all the required .pc files.

This change depends on: https://codereview.chromium.org/1576293002
==========

to

==========
Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default
libdir which makes the build more hermetic and forces the
sysroot to provide all the required .pc files.

This change depends on: https://codereview.chromium.org/1576293002
==========

[Sam Clegg, 2016-01-12 02:15:15]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-12 02:15:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580643002/1

[commit-bot: I haz the power, 2016-01-12 02:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 02:19:31]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam Clegg, 2016-01-12 18:10:27]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-12 18:12:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580643002/40001

[commit-bot: I haz the power, 2016-01-12 18:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 18:41:49]

Dry run: This issue passed the CQ dry run.

[Sam Clegg, 2016-01-12 22:53:09]

gentle ping..

[Sam Clegg, 2016-01-12 22:53:43]

Description was changed from

==========
Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default
libdir which makes the build more hermetic and forces the
sysroot to provide all the required .pc files.

This change depends on: https://codereview.chromium.org/1576293002
==========

to

==========
Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default
libdir which makes the build more hermetic and forces the
sysroot to provide all the required .pc files.
==========

[Lei Zhang, 2016-01-12 23:01:50]

lgtm

https://codereview.chromium.org/1580643002/diff/40001/build/config/linux/pkg-...
File build/config/linux/pkg-config.py (right):

https://codereview.chromium.org/1580643002/diff/40001/build/config/linux/pkg-...
build/config/linux/pkg-config.py:58: # Add the sysroot path to the environment's
PKG_CONFIG_LIBDIR
More like overwrite than add.

[Sam Clegg, 2016-01-12 23:24:59]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2016-01-12 23:25:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1580643002/#ps60001
(title: ";")

[Sam Clegg, 2016-01-12 23:25:13]

https://codereview.chromium.org/1580643002/diff/40001/build/config/linux/pkg-...
File build/config/linux/pkg-config.py (right):

https://codereview.chromium.org/1580643002/diff/40001/build/config/linux/pkg-...
build/config/linux/pkg-config.py:58: # Add the sysroot path to the environment's
PKG_CONFIG_LIBDIR
On 2016/01/12 23:01:50, Lei Zhang wrote:
> More like overwrite than add.

Done

[commit-bot: I haz the power, 2016-01-12 23:25:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580643002/60001

[commit-bot: I haz the power, 2016-01-12 23:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 23:57:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam Clegg, 2016-01-13 00:05:13]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2016-01-13 00:06:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580643002/60001

[commit-bot: I haz the power, 2016-01-13 00:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 00:18:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam Clegg, 2016-01-13 00:46:52]

sbc@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sam Clegg, 2016-01-13 00:46:53]

+scottmg for build/config/OWNERS

[scottmg, 2016-01-13 02:50:44]

rs lgtm

[Sam Clegg, 2016-01-13 18:32:03]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2016-01-13 18:33:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580643002/60001

[commit-bot: I haz the power, 2016-01-13 18:40:25]

Description was changed from

==========
Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default
libdir which makes the build more hermetic and forces the
sysroot to provide all the required .pc files.
==========

to

==========
Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default
libdir which makes the build more hermetic and forces the
sysroot to provide all the required .pc files.
==========

[commit-bot: I haz the power, 2016-01-13 18:40:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-13 18:41:29]

Description was changed from

==========
Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default
libdir which makes the build more hermetic and forces the
sysroot to provide all the required .pc files.
==========

to

==========
Use PKG_CONFIG_LIBDIR to force pkg-config to use sysroot only

Previously we were using PKG_CONFIG_PATH to tell pkg-config
to search the sysroot directories.  However the default
libpath is always added to this path, so pkg-config would
fall back to looking in the system directories.
Using PKG_CONFIG_LIBDIR instead overrides the default
libdir which makes the build more hermetic and forces the
sysroot to provide all the required .pc files.

Committed: https://crrev.com/4d4a9acde47d5e955c12eb0bf3feaa800c2a6f55
Cr-Commit-Position: refs/heads/master@{#369224}
==========

[commit-bot: I haz the power, 2016-01-13 18:41:30]

Patchset 4 (id:??) landed as
https://crrev.com/4d4a9acde47d5e955c12eb0bf3feaa800c2a6f55
Cr-Commit-Position: refs/heads/master@{#369224}

[Dirk Pranke, 2016-01-26 01:31:35]

lgtm (belatedly)