third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html - Issue 1576993003: [css-grid] Fix placement for unknown named grid lines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html

Issue 1576993003: [css-grid] Fix placement for unknown named grid lines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing last review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-position-changed-dynamic.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html

index 8a7152bbc9fa37f3de74322b8c733619304c315f..811f526df15b2df025ffaaf507f52bf4260c4784 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html

@@ -146,8 +146,8 @@

</div>

-<div class="grid" data-expected-width="150" data-expected-height="550">

- <div class="sizedToGridArea namedEndSpanGrowGridInRowDirection" data-offset-x="0" data-offset-y="50" data-expected-width="50" data-expected-height="500"></div>

+<div class="grid" data-expected-width="150" data-expected-height="950">

+ <div class="sizedToGridArea namedEndSpanGrowGridInRowDirection" data-offset-x="0" data-offset-y="350" data-expected-width="50" data-expected-height="600"></div>

</div>

@@ -188,14 +188,14 @@

</div>

-<div class="grid" data-expected-width="150" data-expected-height="150">

- <div class="sizedToGridArea namedGridLineEndPositionStartNegativeInColumnDirection" data-offset-x="0" data-offset-y="0" data-expected-width="150" data-expected-height="50"></div>

+<div class="grid" data-expected-width="1950" data-expected-height="150">

+ <div class="sizedToGridArea namedGridLineEndPositionStartNegativeInColumnDirection" data-offset-x="0" data-offset-y="0" data-expected-width="1950" data-expected-height="50"></div>

</div>

- <div class="sizedToGridArea namedGridLineEndPositionStartNegativeInRowDirection" data-offset-x="0" data-offset-y="0" data-expected-width="450" data-expected-height="50"></div>

+ <div class="sizedToGridArea namedGridLineEndPositionStartNegativeInRowDirection" data-offset-x="0" data-offset-y="0" data-expected-width="200" data-expected-height="50"></div>

</div>