Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html

Issue 1576993003: [css-grid] Fix placement for unknown named grid lines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing last review comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html
index dd4bec17ef0cdb13a4285eddbbc62a2783072e41..e12c8bd62b3d6bd3e47e680262a7adf20d71c9d5 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html
@@ -3,6 +3,11 @@
<head>
<link href="resources/grid.css" rel="stylesheet">
<style>
+.grid {
+ grid-auto-columns: 5px;
+ grid-auto-rows: 5px;
+}
+
.gridWithoutRepeat {
grid-template-columns: [a] 50px [b] 100px [c] 200px [d];
grid-template-rows: [e] 50px [f] 100px [g] 200px [h];
@@ -74,19 +79,19 @@
<div style="position: relative">
<div class="grid gridWithRepeat">
- <div class="sizedToGridArea gridItemBToD" data-offset-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="50"></div>
+ <div class="sizedToGridArea gridItemBToD" data-offset-x="0" data-offset-y="0" data-expected-width="355" data-expected-height="50"></div>
</div>
</div>
<div style="position: relative">
<div class="grid gridWithRepeat">
- <div class="sizedToGridArea gridItemGToH" data-offset-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="50"></div>
+ <div class="sizedToGridArea gridItemGToH" data-offset-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="355"></div>
</div>
</div>
<div style="position: relative">
<div class="grid gridWithoutRepeat">
- <div class="sizedToGridArea gridItemInvalidNegativeGridLine" data-offset-x="0" data-offset-y="50" data-expected-width="350" data-expected-height="300"></div>
+ <div class="sizedToGridArea gridItemInvalidNegativeGridLine" data-offset-x="0" data-offset-y="0" data-expected-width="5" data-expected-height="10"></div>
</div>
</div>
</div>
@@ -105,31 +110,29 @@
<div style="position: relative">
<div class="grid gridWithoutRepeat">
- <!-- There is only one 'b' so we should pick this one. Also span 2 'b' should resolve to the same 'b'.
- Thus being actually 'b' / span 1. -->
- <div class="sizedToGridArea gridItem2BSpan2B" data-offset-x="50" data-offset-y="0" data-expected-width="100" data-expected-height="50"></div>
+ <!-- Consider all the implicit lines to be called 'b' too. -->
+ <div class="sizedToGridArea gridItem2BSpan2B" data-offset-x="355" data-offset-y="0" data-expected-width="10" data-expected-height="50"></div>
</div>
</div>
<div style="position: relative">
<div class="grid gridWithoutRepeat">
- <!-- There is only one 'g' so we should pick this one. Also both initial and final position are equal so
- this is resolved as span 1 / 'g'. -->
- <div class="sizedToGridArea gridItemSpan2GNegativeG" data-offset-x="0" data-offset-y="50" data-expected-width="50" data-expected-height="100"></div>
+ <!-- Consider all the implicit lines to be called 'g' too. -->
+ <div class="sizedToGridArea gridItemSpan2GNegativeG" data-offset-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="160"></div>
</div>
</div>
<div style="position: relative">
<div class="grid gridWithRepeat">
- <!-- There is no 'a' or 'c' so it should default to auto / auto. -->
- <div class="sizedToGridArea gridItemAToSpanC" data-offset-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="50"></div>
+ <!-- There is no 'a' or 'c' so all the implicit lines are considered to have those names. -->
+ <div class="sizedToGridArea gridItemAToSpanC" data-offset-x="355" data-offset-y="0" data-expected-width="5" data-expected-height="50"></div>
</div>
</div>
<div style="position: relative">
<div class="grid gridWithRepeat">
- <!-- There is no 'f' or 'h' so it should default to auto / auto. -->
- <div class="sizedToGridArea gridItemFToSpanH" data-offset-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="50"></div>
+ <!-- There is no 'f' or 'h' so all the implicit lines are considered to have those names. -->
+ <div class="sizedToGridArea gridItemFToSpanH" data-offset-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="360"></div>
</div>
</div>
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698