Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: components/autofill/browser/autofill_external_delegate_unittest.cc

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android compile Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_external_delegate_unittest.cc
diff --git a/components/autofill/browser/autofill_external_delegate_unittest.cc b/components/autofill/browser/autofill_external_delegate_unittest.cc
index 331daacb1b90908ce5227a46ad06a95f39d9b6f1..b1b4881e34fb2ac5fbb4ca695c69230fa4cb6f3d 100644
--- a/components/autofill/browser/autofill_external_delegate_unittest.cc
+++ b/components/autofill/browser/autofill_external_delegate_unittest.cc
@@ -54,8 +54,9 @@ class MockAutofillManagerDelegate
public:
MockAutofillManagerDelegate() {}
- MOCK_METHOD6(ShowAutofillPopup,
+ MOCK_METHOD7(ShowAutofillPopup,
void(const gfx::RectF& element_bounds,
+ bool is_rtl,
const std::vector<base::string16>& values,
const std::vector<base::string16>& labels,
const std::vector<base::string16>& icons,
@@ -147,7 +148,7 @@ TEST_F(AutofillExternalDelegateUnitTest, TestExternalDelegateVirtualCalls) {
// The enums must be cast to ints to prevent compile errors on linux_rel.
EXPECT_CALL(manager_delegate_,
ShowAutofillPopup(
- _, _, _, _,
+ _, _, _, _, _,
testing::ElementsAre(
kAutofillProfileId,
static_cast<int>(WebAutofillClient::MenuItemIDSeparator),
@@ -193,7 +194,7 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateDataList) {
// The enums must be cast to ints to prevent compile errors on linux_rel.
EXPECT_CALL(manager_delegate_,
ShowAutofillPopup(
- _, _, _, _,
+ _, _, _, _, _,
testing::ElementsAre(
static_cast<int>(
WebAutofillClient::MenuItemIDDataListEntry),
@@ -220,7 +221,7 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateDataList) {
// The enum must be cast to an int to prevent compile errors on linux_rel.
EXPECT_CALL(manager_delegate_,
ShowAutofillPopup(
- _, _, _, _,
+ _, _, _, _, _,
testing::ElementsAre(
static_cast<int>(
WebAutofillClient::MenuItemIDDataListEntry)),
@@ -268,7 +269,7 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateClearPreviewedForm) {
// Test that the popup is hidden once we are done editing the autofill field.
TEST_F(AutofillExternalDelegateUnitTest,
ExternalDelegateHidePopupAfterEditing) {
- EXPECT_CALL(manager_delegate_, ShowAutofillPopup(_, _, _, _, _, _));
+ EXPECT_CALL(manager_delegate_, ShowAutofillPopup(_, _, _, _, _, _, _));
autofill::GenerateTestAutofillPopup(external_delegate_.get());
EXPECT_CALL(manager_delegate_, HideAutofillPopup());
@@ -296,7 +297,7 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
// The enums must be cast to ints to prevent compile errors on linux_rel.
EXPECT_CALL(manager_delegate_,
ShowAutofillPopup(
- _, _, _, _,
+ _, _, _, _, _,
testing::ElementsAre(
static_cast<int>(
WebAutofillClient::MenuItemIDPasswordEntry)),

Powered by Google App Engine
This is Rietveld 408576698