chrome/browser/ui/autofill/autofill_popup_controller_impl.h - Issue 15769018: [Autofill] Determine Popup RTLness from page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android compile Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller.h ('k') | chrome/browser/ui/autofill/autofill_popup_controller_impl.cc » ('j') | components/autofill/browser/autofill_manager_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

index 7ecf397f3d4d1e04ad31a3845668e293ef84d9f0..201342663949f922642fa177b2c30d261b6840a6 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

@@ -40,7 +40,8 @@ class AutofillPopupControllerImpl : public AutofillPopupController,

base::WeakPtr<AutofillPopupControllerImpl> previous,

base::WeakPtr<AutofillPopupDelegate> delegate,

gfx::NativeView container_view,

- const gfx::RectF& element_bounds);

+ const gfx::RectF& element_bounds,

+ bool is_rtl);

// Shows the popup, or updates the existing popup with the given values.

void Show(const std::vector<string16>& names,

@@ -67,7 +68,8 @@ class AutofillPopupControllerImpl : public AutofillPopupController,

AutofillPopupControllerImpl(base::WeakPtr<AutofillPopupDelegate> delegate,

gfx::NativeView container_view,

- const gfx::RectF& element_bounds);

+ const gfx::RectF& element_bounds,

+ bool is_rtl);

Ilya Sherman 2013/06/06 09:04:04 Please pass a value from base::i18n::TextDirection

csharp 2013/06/06 14:13:53 Done.

virtual ~AutofillPopupControllerImpl();

// AutofillPopupController implementation.

@@ -83,6 +85,7 @@ class AutofillPopupControllerImpl : public AutofillPopupController,

virtual const gfx::Rect& popup_bounds() const OVERRIDE;

virtual gfx::NativeView container_view() const OVERRIDE;

virtual const gfx::RectF& element_bounds() const OVERRIDE;

+ virtual bool is_rtl() const OVERRIDE;

virtual const std::vector<string16>& names() const OVERRIDE;

virtual const std::vector<string16>& subtexts() const OVERRIDE;

@@ -191,6 +194,9 @@ class AutofillPopupControllerImpl : public AutofillPopupController,

// The bounds of the Autofill popup.

gfx::Rect popup_bounds_;

+ // If the popup should be displayed RTL.

+ bool is_rtl_;

// The current Autofill query values.

std::vector<string16> names_;

std::vector<string16> subtexts_;