[Autofill] Determine Popup RTLness from page

chrome/browser/ui/autofill/autofill_popup_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/string16.h"
@@ skipping 22 matching lines @@
 class AutofillPopupControllerImpl : public AutofillPopupController,
                                     public content::KeyboardListener {
  public:
   // Creates a new |AutofillPopupControllerImpl|, or reuses |previous| if
   // the construction arguments are the same. |previous| may be invalidated by
   // this call.
   static base::WeakPtr<AutofillPopupControllerImpl> GetOrCreate(
       base::WeakPtr<AutofillPopupControllerImpl> previous,
       base::WeakPtr<AutofillPopupDelegate> delegate,
       gfx::NativeView container_view,
-      const gfx::RectF& element_bounds);
+      const gfx::RectF& element_bounds,
+      bool is_rtl);
 
   // Shows the popup, or updates the existing popup with the given values.
   void Show(const std::vector<string16>& names,
             const std::vector<string16>& subtexts,
             const std::vector<string16>& icons,
             const std::vector<int>& identifiers);
 
   // Hides the popup and destroys the controller. This also invalidates
   // |delegate_|.
   virtual void Hide() OVERRIDE;
 
   // Invoked when the view was destroyed by by someone other than this class.
   virtual void ViewDestroyed() OVERRIDE;
 
   // KeyboardListener implementation.
   virtual bool HandleKeyPressEvent(
       const content::NativeWebKeyboardEvent& event) OVERRIDE;
 
  protected:
   FRIEND_TEST_ALL_PREFIXES(AutofillExternalDelegateBrowserTest,
                            CloseWidgetAndNoLeaking);
   FRIEND_TEST_ALL_PREFIXES(AutofillPopupControllerUnitTest,
                            ProperlyResetController);
 
   AutofillPopupControllerImpl(base::WeakPtr<AutofillPopupDelegate> delegate,
                               gfx::NativeView container_view,
-                              const gfx::RectF& element_bounds);
+                              const gfx::RectF& element_bounds,
+                              bool is_rtl);

[Ilya Sherman, 2013/06/06 09:04:04]

Please pass a value from base::i18n::TextDirection rather than a boolean.

[csharp, 2013/06/06 14:13:53]

Done.

   virtual ~AutofillPopupControllerImpl();
 
   // AutofillPopupController implementation.
   virtual void UpdateBoundsAndRedrawPopup() OVERRIDE;
   virtual void MouseHovered(int x, int y) OVERRIDE;
   virtual void MouseClicked(int x, int y) OVERRIDE;
   virtual void MouseExitedPopup() OVERRIDE;
   virtual void AcceptSuggestion(size_t index) OVERRIDE;
   virtual int GetIconResourceID(const string16& resource_name) OVERRIDE;
   virtual bool CanDelete(size_t index) const OVERRIDE;
   virtual gfx::Rect GetRowBounds(size_t index) OVERRIDE;
   virtual void SetPopupBounds(const gfx::Rect& bounds) OVERRIDE;
   virtual const gfx::Rect& popup_bounds() const OVERRIDE;
   virtual gfx::NativeView container_view() const OVERRIDE;
   virtual const gfx::RectF& element_bounds() const OVERRIDE;
+  virtual bool is_rtl() const OVERRIDE;
 
   virtual const std::vector<string16>& names() const OVERRIDE;
   virtual const std::vector<string16>& subtexts() const OVERRIDE;
   virtual const std::vector<string16>& icons() const OVERRIDE;
   virtual const std::vector<int>& identifiers() const OVERRIDE;
 #if !defined(OS_ANDROID)
   virtual const gfx::Font& GetNameFontForRow(size_t index) const OVERRIDE;
   virtual const gfx::Font& subtext_font() const OVERRIDE;
 #endif
   virtual int selected_line() const OVERRIDE;
@@ skipping 88 matching lines @@
   base::WeakPtr<AutofillPopupDelegate> delegate_;
   gfx::NativeView container_view_;  // Weak reference.
 
   // The bounds of the text element that is the focus of the Autofill.
   // These coordinates are in screen space.
   const gfx::RectF element_bounds_;
 
   // The bounds of the Autofill popup.
   gfx::Rect popup_bounds_;
 
+  // If the popup should be displayed RTL.
+  bool is_rtl_;
+
   // The current Autofill query values.
   std::vector<string16> names_;
   std::vector<string16> subtexts_;
   std::vector<string16> icons_;
   std::vector<int> identifiers_;
 
   // Since names_ can be elided to ensure that it fits on the screen, we need to
   // keep an unelided copy of the names to be able to pass to the delegate.
   std::vector<string16> full_names_;
 
 #if !defined(OS_ANDROID)
   // The fonts for the popup text.
   gfx::Font name_font_;
   gfx::Font subtext_font_;
   gfx::Font warning_font_;
 #endif
 
   // The line that is currently selected by the user.
   // |kNoSelection| indicates that no line is currently selected.
   int selected_line_;
 
   base::WeakPtrFactory<AutofillPopupControllerImpl> weak_ptr_factory_;
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_