Add rudimentary mash shelf functionality.

Add rudimentary mash shelf functionality.

Add UserWindow[Controller|Observer] interfaces and impls.
Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.
Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org

Committed: https://crrev.com/85273d0c56790d470d9d002990da25ae6fb9c950
Cr-Commit-Position: refs/heads/master@{#369330}

[msw, 2016-01-13 20:15:44]

Patchset #10 (id:180001) has been deleted

[msw, 2016-01-13 20:15:52]

Description was changed from

==========
Add rudimentary mash shelf functionality.

BUG=557406
==========

to

==========
Add rudimentary mash shelf functionality.

Add mus UserWindow[Controller|Observer] interfaces.
Implement UserWindowController in WindowManagerImpl class.
Implement UserWindowObserver in ShelfView class.

Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.

Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org
==========

[msw, 2016-01-13 20:15:53]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-01-13 20:16:10]

Hey Scott, please take a look; thanks!

[sky, 2016-01-13 21:17:17]

https://codereview.chromium.org/1576683002/diff/220001/components/mus/public/...
File components/mus/public/interfaces/user_window_controller.mojom (right):

https://codereview.chromium.org/1576683002/diff/220001/components/mus/public/...
components/mus/public/interfaces/user_window_controller.mojom:1: // Copyright
2015 The Chromium Authors. All rights reserved.
2016.
Also, I don't think this interface should be here. UserWindowController isn't
implemented by mus or depended on by a layer that requires it to be here. I
recommend mash/wm/public/interfaces.

https://codereview.chromium.org/1576683002/diff/220001/components/mus/public/...
components/mus/public/interfaces/user_window_controller.mojom:10:
OnUserWindowAdded(uint32 window_id);
I recommend an initial function that is always called with the current state.
That way the observer can stay up to date and there aren't ordering problems if
you have a query interface.

https://codereview.chromium.org/1576683002/diff/220001/mash/shelf/shelf_appli...
File mash/shelf/shelf_application.cc (right):

https://codereview.chromium.org/1576683002/diff/220001/mash/shelf/shelf_appli...
mash/shelf/shelf_application.cc:34: class ShelfView : public
views::WidgetDelegateView,
This is fine for now, but no doubt this is going to get more complex. I would
move it into it's own .h/.cc, but if you want to do that later I'm fine with
that.

https://codereview.chromium.org/1576683002/diff/220001/mash/shelf/shelf_appli...
mash/shelf/shelf_application.cc:50: views::LabelButton* views_examples =
If you click one of these buttons do you end up with two buttons for the same
thing? One to launch and one to focus? I suppose for a simple case that is fine.

https://codereview.chromium.org/1576683002/diff/220001/mash/wm/window_manager...
File mash/wm/window_manager_impl.h (right):

https://codereview.chromium.org/1576683002/diff/220001/mash/wm/window_manager...
mash/wm/window_manager_impl.h:67: mus::mojom::UserWindowObserverPtr
user_window_observer_;
I suspect this code will become more complex, and likely specific to the shelf.
Can you move it to its own class?

[msw, 2016-01-13 22:53:38]

Patchset #12 (id:240001) has been deleted

[msw, 2016-01-13 22:54:27]

Description was changed from

==========
Add rudimentary mash shelf functionality.

Add mus UserWindow[Controller|Observer] interfaces.
Implement UserWindowController in WindowManagerImpl class.
Implement UserWindowObserver in ShelfView class.

Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.

Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org
==========

to

==========
Add rudimentary mash shelf functionality.

Add UserWindow[Controller|Observer] interfaces and impls.
Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.
Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org
==========

[msw, 2016-01-13 22:54:56]

Please take another look; thanks!

https://codereview.chromium.org/1576683002/diff/220001/components/mus/public/...
File components/mus/public/interfaces/user_window_controller.mojom (right):

https://codereview.chromium.org/1576683002/diff/220001/components/mus/public/...
components/mus/public/interfaces/user_window_controller.mojom:1: // Copyright
2015 The Chromium Authors. All rights reserved.
On 2016/01/13 21:17:17, sky wrote:
> 2016.
> Also, I don't think this interface should be here. UserWindowController isn't
> implemented by mus or depended on by a layer that requires it to be here. I
> recommend mash/wm/public/interfaces.

Done.

https://codereview.chromium.org/1576683002/diff/220001/components/mus/public/...
components/mus/public/interfaces/user_window_controller.mojom:10:
OnUserWindowAdded(uint32 window_id);
On 2016/01/13 21:17:17, sky wrote:
> I recommend an initial function that is always called with the current state.
> That way the observer can stay up to date and there aren't ordering problems
if
> you have a query interface.

Done; this gets the quick launcher window now too!
(I hope I captured your intent correctly)

https://codereview.chromium.org/1576683002/diff/220001/mash/shelf/shelf_appli...
File mash/shelf/shelf_application.cc (right):

https://codereview.chromium.org/1576683002/diff/220001/mash/shelf/shelf_appli...
mash/shelf/shelf_application.cc:34: class ShelfView : public
views::WidgetDelegateView,
On 2016/01/13 21:17:17, sky wrote:
> This is fine for now, but no doubt this is going to get more complex. I would
> move it into it's own .h/.cc, but if you want to do that later I'm fine with
> that.

Yeah, this is just a POC to shape initial interfaces.
Added shelf_view.[h|cc]; I'll split out the model, etc. later.

https://codereview.chromium.org/1576683002/diff/220001/mash/shelf/shelf_appli...
mash/shelf/shelf_application.cc:50: views::LabelButton* views_examples =
On 2016/01/13 21:17:17, sky wrote:
> If you click one of these buttons do you end up with two buttons for the same
> thing? One to launch and one to focus? I suppose for a simple case that is
fine.

Yes, these are just simple examples to launch applications, I can definitely
remove them for now if desired. I'm working on a follow-up CL to get the actual
window titles (and possibly the application name or some sort of group id) so
the shelf has a way to merge these 'pinned' buttons with the open user windows.
This will all be more fleshed out with a ShelfModel, etc. later.

https://codereview.chromium.org/1576683002/diff/220001/mash/wm/window_manager...
File mash/wm/window_manager_impl.h (right):

https://codereview.chromium.org/1576683002/diff/220001/mash/wm/window_manager...
mash/wm/window_manager_impl.h:67: mus::mojom::UserWindowObserverPtr
user_window_observer_;
On 2016/01/13 21:17:17, sky wrote:
> I suspect this code will become more complex, and likely specific to the
shelf.
> Can you move it to its own class?

Done.

[sky, 2016-01-14 00:19:21]

LGTM

https://codereview.chromium.org/1576683002/diff/260001/mash/wm/window_manager...
File mash/wm/window_manager_application.h (right):

https://codereview.chromium.org/1576683002/diff/260001/mash/wm/window_manager...
mash/wm/window_manager_application.h:139:
ScopedVector<mojo::InterfaceRequest<mash::wm::mojom::UserWindowController>>
ScopedVector is deprecated. See the header.

[msw, 2016-01-14 00:51:30]

The CQ bit was checked by msw@chromium.org

[msw, 2016-01-14 00:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1576683002/#ps300001
(title: "git cl format")

[commit-bot: I haz the power, 2016-01-14 00:56:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576683002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576683002/300001

[commit-bot: I haz the power, 2016-01-14 03:01:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 03:01:46]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)

[msw, 2016-01-14 04:55:42]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-01-14 04:56:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576683002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576683002/300001

[commit-bot: I haz the power, 2016-01-14 05:05:23]

Description was changed from

==========
Add rudimentary mash shelf functionality.

Add UserWindow[Controller|Observer] interfaces and impls.
Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.
Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org
==========

to

==========
Add rudimentary mash shelf functionality.

Add UserWindow[Controller|Observer] interfaces and impls.
Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.
Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-01-14 05:05:24]

Committed patchset #14 (id:300001)

[commit-bot: I haz the power, 2016-01-14 05:06:38]

Description was changed from

==========
Add rudimentary mash shelf functionality.

Add UserWindow[Controller|Observer] interfaces and impls.
Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.
Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org
==========

to

==========
Add rudimentary mash shelf functionality.

Add UserWindow[Controller|Observer] interfaces and impls.
Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.
Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org

Committed: https://crrev.com/85273d0c56790d470d9d002990da25ae6fb9c950
Cr-Commit-Position: refs/heads/master@{#369330}
==========

[commit-bot: I haz the power, 2016-01-14 05:06:39]

Patchset 14 (id:??) landed as
https://crrev.com/85273d0c56790d470d9d002990da25ae6fb9c950
Cr-Commit-Position: refs/heads/master@{#369330}