components/mus/public/interfaces/user_window_controller.mojom - Issue 1576683002: Add rudimentary mash shelf functionality.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/mus/public/interfaces/user_window_controller.mojom

Issue 1576683002: Add rudimentary mash shelf functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync and rebase. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	sky 2016/01/13 21:17:17 2016. Also, I don't think this interface should be 2016. Also, I don't think this interface should be here. UserWindowController isn't implemented by mus or depended on by a layer that requires it to be here. I recommend mash/wm/public/interfaces. msw 2016/01/13 22:54:56 Done. Show quoted text On 2016/01/13 21:17:17, sky wrote: > 2016. > Also, I don't think this interface should be here. UserWindowController isn't > implemented by mus or depended on by a layer that requires it to be here. I > recommend mash/wm/public/interfaces. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mus.mojom;

	6

	7 // An observer of user windows within mojom::CONTAINER_USER_WINDOWS.

	8 // TODO(msw): Observe focus changes, title/icon changes, etc.

	9 interface UserWindowObserver {

	10 OnUserWindowAdded(uint32 window_id);
	sky 2016/01/13 21:17:17 I recommend an initial function that is always cal I recommend an initial function that is always called with the current state. That way the observer can stay up to date and there aren't ordering problems if you have a query interface. msw 2016/01/13 22:54:56 Done; this gets the quick launcher window now too! Show quoted text On 2016/01/13 21:17:17, sky wrote: > I recommend an initial function that is always called with the current state. > That way the observer can stay up to date and there aren't ordering problems if > you have a query interface. Done; this gets the quick launcher window now too! (I hope I captured your intent correctly)
	11 OnUserWindowRemoved(uint32 window_id);

	12 };

	13

	14 // An interface allowing system UIs to manage the set of user windows.

	15 // TODO(msw): Add minimization, restoration, opening a chooser view, etc.

	16 interface UserWindowController {

	17 AddUserWindowObserver(UserWindowObserver observer);

	18 FocusUserWindow(uint32 window_id);

	19 };

OLD	NEW

« no previous file with comments | « components/mus/public/interfaces/BUILD.gn ('k') | mash/BUILD.gn » ('j') | mash/shelf/shelf_application.cc » ('J')