Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1576153003: Encode nil datastore keys as PTNull. (Closed)

Created:
4 years, 11 months ago by dnj
Modified:
4 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Encode nil datastore keys as PTNull. This fixes a panic in serialize when it is asked to serialize a nil *ds.Key, causing it to dereference its fields. Instead, a *ds.Key is serialized as a PTNull entry like datastore. Add some tests to assert proper conversion and serialization. BUG= Committed: https://github.com/luci/gae/commit/273b8ea01f0d03bd19cd4c14a9b1ba790d125306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M service/datastore/properties.go View 1 chunk +7 lines, -0 lines 0 comments Download
M service/datastore/properties_test.go View 1 chunk +13 lines, -0 lines 0 comments Download
M service/datastore/serialize/serialize_test.go View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
PTAL
4 years, 11 months ago (2016-01-12 20:18:12 UTC) #2
iannucci
lgtm
4 years, 11 months ago (2016-01-12 20:42:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1576153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1576153003/1
4 years, 11 months ago (2016-01-12 21:10:59 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 21:15:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/273b8ea01f0d03bd19cd4c14a9b1ba790d125306

Powered by Google App Engine
This is Rietveld 408576698