service/datastore/properties.go - Issue 1576153003: Encode nil datastore keys as PTNull.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/properties.go

Issue 1576153003: Encode nil datastore keys as PTNull. (Closed) Base URL: https://github.com/luci/gae@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/properties.go

diff --git a/service/datastore/properties.go b/service/datastore/properties.go

index f266362cd6bd31bc06245eb175eecda42c1c829d..e8c1813496122a0c7368038245f80931dfe2835f 100644

--- a/service/datastore/properties.go

+++ b/service/datastore/properties.go

@@ -324,6 +324,13 @@ func UpconvertUnderlyingType(o interface{}) interface{} {

}

+ switch t {

+ case typeOfKey:

+ if v.IsNil() {

+ return nil

+ }

return o

}

« no previous file with comments | « no previous file | service/datastore/properties_test.go » ('j') | no next file with comments »