Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1576093005: Create master.tryserver.libyuv bucket (Closed)

Created:
4 years, 11 months ago by nodir
Modified:
4 years, 11 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@config
Target Ref:
refs/heads/infra/config
Project:
libyuv
Visibility:
Public.

Description

Create master.tryserver.libyuv bucket Also README.md, OWNERS and other std files R=kjellander@chromium.org BUG=551062 Committed: 1773ecdd764266cfe93521bb5e3a3e6f42dedafd

Patch Set 1 #

Total comments: 9

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A codereview.settings View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cr-buildbucket.cfg View 1 chunk +23 lines, -0 lines 0 comments Download
A project.cfg View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
nodir
PTAL
4 years, 11 months ago (2016-01-12 17:36:12 UTC) #1
kjellander_chromium
lgtm with comments addressed. +fbarchard for question about the project name. https://codereview.chromium.org/1576093005/diff/1/codereview.settings File codereview.settings (right): ...
4 years, 11 months ago (2016-01-12 17:43:22 UTC) #3
nodir
https://codereview.chromium.org/1576093005/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/1576093005/diff/1/codereview.settings#newcode2 codereview.settings:2: # The LibYuv code review is via WebRtc's code ...
4 years, 11 months ago (2016-01-12 17:46:37 UTC) #4
kjellander_chromium
https://codereview.chromium.org/1576093005/diff/1/cr-buildbucket.cfg File cr-buildbucket.cfg (right): https://codereview.chromium.org/1576093005/diff/1/cr-buildbucket.cfg#newcode10 cr-buildbucket.cfg:10: name: "master.tryserver.libyuv" On 2016/01/12 17:46:37, nodir wrote: > On ...
4 years, 11 months ago (2016-01-12 18:07:56 UTC) #5
nodir
https://codereview.chromium.org/1576093005/diff/1/cr-buildbucket.cfg File cr-buildbucket.cfg (right): https://codereview.chromium.org/1576093005/diff/1/cr-buildbucket.cfg#newcode10 cr-buildbucket.cfg:10: name: "master.tryserver.libyuv" On 2016/01/12 18:07:56, kjellander (chromium) wrote: > ...
4 years, 11 months ago (2016-01-12 18:16:56 UTC) #6
kjellander_chromium
still lgtm https://codereview.chromium.org/1576093005/diff/1/cr-buildbucket.cfg File cr-buildbucket.cfg (right): https://codereview.chromium.org/1576093005/diff/1/cr-buildbucket.cfg#newcode10 cr-buildbucket.cfg:10: name: "master.tryserver.libyuv" On 2016/01/12 18:16:56, nodir wrote: ...
4 years, 11 months ago (2016-01-12 20:01:17 UTC) #7
nodir
On 2016/01/12 20:01:17, kjellander (chromium) wrote: > still lgtm > > https://codereview.chromium.org/1576093005/diff/1/cr-buildbucket.cfg > File cr-buildbucket.cfg ...
4 years, 11 months ago (2016-01-12 20:05:21 UTC) #8
nodir
4 years, 11 months ago (2016-01-12 20:07:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1773ecdd764266cfe93521bb5e3a3e6f42dedafd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698