Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1575783002: components: fix the inclusion of some header files (Closed)

Created:
4 years, 11 months ago by tfarina
Modified:
4 years, 11 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org, battre
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components: fix the inclusion of some header files These header files are not system header files and thus do not need to be included using <> rather than "". This was reported by Gergely Nagy at gn-dev mailing list: https://groups.google.com/a/chromium.org/d/topic/gn-dev/JIM6OF6J10E/discussion BUG=None R=rkc@chromium.org,vabr@chromium.org,sorin@chromium.org Committed: https://crrev.com/be264faf0286a508b23e181d3cb25723f2eff2bf Cr-Commit-Position: refs/heads/master@{#368644}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/feedback/anonymizer_tool.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_ui_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/utils.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
tfarina
4 years, 11 months ago (2016-01-10 19:34:06 UTC) #1
vabr (Chromium)
components/password_manager/core/browser/password_ui_utils.cc LGTM, thanks for fixing this. Cheers, Vaclav
4 years, 11 months ago (2016-01-11 09:27:30 UTC) #2
battre
anonymizer_tool LGTM as well but disclaimer, I had several of these fixes in https://codereview.chromium.org/1543633003/ already ...
4 years, 11 months ago (2016-01-11 09:38:06 UTC) #4
Sorin Jianu
lgtm Thank you!
4 years, 11 months ago (2016-01-11 18:03:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575783002/20001
4 years, 11 months ago (2016-01-11 18:47:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 19:55:08 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:56:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be264faf0286a508b23e181d3cb25723f2eff2bf
Cr-Commit-Position: refs/heads/master@{#368644}

Powered by Google App Engine
This is Rietveld 408576698