Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1575763002: Make `content` target build without unused data members on Linux. (Closed)

Created:
4 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 11 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, jkarlin+watch_chromium.org, kalyank, kinuko+watch, maxbogue+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, qsr+mojo_chromium.org, sievers+watch_chromium.org, tim+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@use_disallow_copy_assign_linux_only
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make `content` target build without unused data members on Linux. This allows the `content` target to build with the following CL applied: https://codereview.chromium.org/1222403002 BUG=447445 Committed: https://crrev.com/aabef768e591d0bfa62a4e39b8eaf0ebf32bbe19 Cr-Commit-Position: refs/heads/master@{#369564}

Patch Set 1 #

Patch Set 2 : no deps #

Total comments: 6

Patch Set 3 : review comments #

Patch Set 4 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -73 lines) Patch
M components/bitmap_uploader/bitmap_uploader.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/webrtc_identity_store.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 2 3 chunks +1 line, -5 lines 0 comments Download
M content/browser/webui/url_data_manager_backend_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/background_sync/background_sync_client_impl.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M content/renderer/background_sync/background_sync_client_impl.cc View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_android.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_linux.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_mac.mm View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/shared_worker_repository.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/websharedworker_proxy.h View 1 2 2 chunks +1 line, -14 lines 0 comments Download
M content/renderer/websharedworker_proxy.cc View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M media/blink/url_index.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/host/child_process.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575763002/1
4 years, 11 months ago (2016-01-10 17:11:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575763002/20001
4 years, 11 months ago (2016-01-10 17:29:07 UTC) #5
mlamouri (slow - plz ping)
4 years, 11 months ago (2016-01-10 17:31:01 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 09:06:40 UTC) #9
jam
lgtm with comments https://codereview.chromium.org/1575763002/diff/20001/content/browser/webui/url_data_manager_backend.cc File content/browser/webui/url_data_manager_backend.cc (left): https://codereview.chromium.org/1575763002/diff/20001/content/browser/webui/url_data_manager_backend.cc#oldcode490 content/browser/webui/url_data_manager_backend.cc:490: AppCacheServiceImpl* appcache_service, should remove this parameter ...
4 years, 11 months ago (2016-01-13 16:17:50 UTC) #10
mlamouri (slow - plz ping)
https://codereview.chromium.org/1575763002/diff/20001/content/browser/webui/url_data_manager_backend.cc File content/browser/webui/url_data_manager_backend.cc (left): https://codereview.chromium.org/1575763002/diff/20001/content/browser/webui/url_data_manager_backend.cc#oldcode490 content/browser/webui/url_data_manager_backend.cc:490: AppCacheServiceImpl* appcache_service, On 2016/01/13 at 16:17:50, jam wrote: > ...
4 years, 11 months ago (2016-01-14 20:13:39 UTC) #13
mlamouri (slow - plz ping)
https://codereview.chromium.org/1575763002/diff/20001/content/renderer/websharedworker_proxy.cc File content/renderer/websharedworker_proxy.cc (left): https://codereview.chromium.org/1575763002/diff/20001/content/renderer/websharedworker_proxy.cc#oldcode21 content/renderer/websharedworker_proxy.cc:21: int render_frame_route_id) On 2016/01/13 at 16:17:50, jam wrote: > ...
4 years, 11 months ago (2016-01-14 20:14:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575763002/40001
4 years, 11 months ago (2016-01-14 20:15:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/102375) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-14 20:26:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575763002/60001
4 years, 11 months ago (2016-01-14 20:38:23 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-14 22:08:59 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 22:11:10 UTC) #23
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/aabef768e591d0bfa62a4e39b8eaf0ebf32bbe19
Cr-Commit-Position: refs/heads/master@{#369564}

Powered by Google App Engine
This is Rietveld 408576698