Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1222403002: Use "= delete" for DISALLOW_COPY_AND_ASSIGN on Linux. (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 6 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use "= delete" for DISALLOW_COPY_AND_ASSIGN on Linux. This will guarantee that the error will happen at compile time and will enable errors when a class member isn't used. BUG=447156

Patch Set 1 #

Patch Set 2 : linux only #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M base/macros.h View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/snappy/linux/snappy-stubs-public.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
mlamouri (slow - plz ping)
I think this is ready to land. thakis@ and danakj@, can one of you PTAL? ...
4 years, 11 months ago (2016-01-16 16:32:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1222403002/40001
4 years, 11 months ago (2016-01-16 16:32:34 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/159752)
4 years, 11 months ago (2016-01-16 16:40:43 UTC) #8
Nico
4 years, 11 months ago (2016-01-16 18:28:00 UTC) #9
On 2016/01/16 16:40:43, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

Nice! Do you need to occlude buildconfig.h in the macros file? Can you update
README.chromium for the third party change? What's with all the red trybots?

Powered by Google App Engine
This is Rietveld 408576698