components/content_settings/core/browser/content_settings_registry.cc - Issue 1575623002: Disable Web Notifications in Incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_registry.cc

Issue 1575623002: Disable Web Notifications in Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permfix

Patch Set: No Profile* in WebsiteSettingsPopupView Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/website_settings/website_settings_popup_view.cc ('K') | « chrome/browser/ui/website_settings/website_settings_ui.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_registry.cc

diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc

index c16c7830755e6d940cde67325019a5a63fbc0457..34510e33592bba407f8e5fab70281b6f35b6ac58 100644

--- a/components/content_settings/core/browser/content_settings_registry.cc

+++ b/components/content_settings/core/browser/content_settings_registry.cc

@@ -173,6 +173,8 @@ void ContentSettingsRegistry::Init() {

ValidSettings(CONTENT_SETTING_ALLOW, CONTENT_SETTING_BLOCK,

CONTENT_SETTING_ASK),

WebsiteSettingsInfo::REQUESTING_ORIGIN_ONLY_SCOPE,

+ // See also NotificationPermissionContext::DecidePermission which

+ // implements additional incognito exceptions.

ContentSettingsInfo::INHERIT_IN_INCOGNITO_EXCEPT_ALLOW);

« chrome/browser/ui/views/website_settings/website_settings_popup_view.cc ('K') | « chrome/browser/ui/website_settings/website_settings_ui.cc ('k') | no next file » | no next file with comments »