Disable Web Notifications in Incognito

chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
index fd8a3717a276ec062a39751e35062036508edb64..65fd94fe15262c14c23bf727ab1fcac30666cfd0 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
@@ -590,6 +590,9 @@ void WebsiteSettingsPopupView::SetCookieInfo(
     WebsiteSettingsUI::PermissionInfo info;
     info.type = CONTENT_SETTINGS_TYPE_COOKIES;
     info.setting = CONTENT_SETTING_ALLOW;
+    info.is_incognito =
+        Profile::FromBrowserContext(web_contents_->GetBrowserContext())

[palmer, 2016/01/14 19:26:19]

I *think* it is possible for this to return nullptr? If so, it'd be good to
check for that. I could be wrong though.

[johnme, 2016/01/14 23:34:48]

web_contents_ is guaranteed to be non-null (despite the various null-checks in
this class!) since the constructor calls
TabSpecificContentSettings::FromWebContents(web_contents) which would deref null
otherwise, and web_contents_ is never written to afterwards.

Then WebContents::GetBrowserContext() delegates to
NavigationController::GetBrowserContext() which is commented as "can never be
nullptr".

Finally, Profile::FromBrowserContext is just a static cast.

So this should be safe.

+            ->IsOffTheRecord();
     views::ImageView* icon = new views::ImageView();
     const gfx::Image& image = WebsiteSettingsUI::GetPermissionIcon(info);
     icon->SetImage(image.ToImageSkia());