Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1989)

Unified Diff: chrome/browser/ui/website_settings/permission_menu_model_unittest.cc

Issue 1575623002: Disable Web Notifications in Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permfix
Patch Set: No Profile* in WebsiteSettingsPopupView Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
diff --git a/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
index 747e2e3bafee167ea706eca7193cde039236e2ed..718f1080e927291eb0a940a9e1a91f4861290ebe 100644
--- a/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
+++ b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
@@ -31,6 +31,7 @@ TEST(PermissionMenuModelTest, TestDefault) {
permission.type = CONTENT_SETTINGS_TYPE_COOKIES;
permission.setting = CONTENT_SETTING_ALLOW;
permission.default_setting = CONTENT_SETTING_ALLOW;
+ permission.is_incognito = false;
PermissionMenuModel model(
GURL("http://www.google.com"), permission, callback.callback());
EXPECT_EQ(3, model.GetItemCount());
@@ -45,6 +46,7 @@ TEST(PermissionMenuModelTest, TestDefaultMediaHttp) {
permission.type = type;
permission.setting = CONTENT_SETTING_ALLOW;
permission.default_setting = CONTENT_SETTING_ALLOW;
+ permission.is_incognito = false;
PermissionMenuModel model(
GURL("http://www.google.com"), permission, callback.callback());
EXPECT_EQ(2, model.GetItemCount());
@@ -65,6 +67,7 @@ TEST(PermissionMenuModelTest, TestFullscreenMouseLockFileUrl) {
permission.type = CONTENT_SETTINGS_TYPE_FULLSCREEN;
permission.setting = CONTENT_SETTING_ASK;
permission.default_setting = CONTENT_SETTING_ASK;
+ permission.is_incognito = false;
PermissionMenuModel fullscreen_model(GURL("file:///test.html"), permission,
callback.callback());
EXPECT_EQ(1, fullscreen_model.GetItemCount());
@@ -80,3 +83,21 @@ TEST(PermissionMenuModelTest, TestFullscreenMouseLockFileUrl) {
l10n_util::GetStringUTF16(IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_ASK),
fullscreen_model.GetLabelAt(0));
}
+
+TEST(PermissionMenuModelTest, TestIncognitoNotifications) {
+ TestCallback callback;
+ WebsiteSettingsUI::PermissionInfo permission;
+ permission.type = CONTENT_SETTINGS_TYPE_NOTIFICATIONS;
+ permission.setting = CONTENT_SETTING_ASK;
+ permission.default_setting = CONTENT_SETTING_ASK;
+
+ permission.is_incognito = false;
+ PermissionMenuModel regular_model(GURL("https://www.google.com"), permission,
+ callback.callback());
+ EXPECT_EQ(3, regular_model.GetItemCount());
+
+ permission.is_incognito = true;
+ PermissionMenuModel incognito_model(GURL("https://www.google.com"),
+ permission, callback.callback());
+ EXPECT_EQ(2, incognito_model.GetItemCount());
+}

Powered by Google App Engine
This is Rietveld 408576698