Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2864)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 1575623002: Disable Web Notifications in Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permfix
Patch Set: No Profile* in WebsiteSettingsPopupView Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
index 0c657f2e614a14696a297200dbd241bcf7b1474e..50f2a4fb1800385fa79f29eb3455ce025ff25afa 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
@@ -110,6 +110,9 @@ void PermissionBubbleManager::AddRequest(PermissionBubbleRequest* request) {
.IsSameOriginWith(url::Origin(request->GetRequestingHostname()));
// Don't re-add an existing request or one with a duplicate text request.
+ // TODO(johnme): Instead of dropping duplicate requests, we should queue them
+ // and eventually run their PermissionGranted/PermissionDenied/Cancelled
+ // callback (crbug.com/577313).
bool same_object = false;
if (ExistingRequest(request, requests_, &same_object) ||
ExistingRequest(request, queued_requests_, &same_object) ||

Powered by Google App Engine
This is Rietveld 408576698