Disable Web Notifications in Incognito

chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <vector>
@@ skipping 572 matching lines @@
     // link.
     column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
                           views::GridLayout::USE_PREF, 0, 0);
 
     layout->AddPaddingRow(1, 5);
 
     layout->StartRow(1, site_data_content_column);
     WebsiteSettingsUI::PermissionInfo info;
     info.type = CONTENT_SETTINGS_TYPE_COOKIES;
     info.setting = CONTENT_SETTING_ALLOW;
+    info.is_incognito =
+        Profile::FromBrowserContext(web_contents_->GetBrowserContext())

[palmer, 2016/01/14 19:26:19]

I *think* it is possible for this to return nullptr? If so, it'd be good to
check for that. I could be wrong though.

[johnme, 2016/01/14 23:34:48]

web_contents_ is guaranteed to be non-null (despite the various null-checks in
this class!) since the constructor calls
TabSpecificContentSettings::FromWebContents(web_contents) which would deref null
otherwise, and web_contents_ is never written to afterwards.

Then WebContents::GetBrowserContext() delegates to
NavigationController::GetBrowserContext() which is commented as "can never be
nullptr".

Finally, Profile::FromBrowserContext is just a static cast.

So this should be safe.

+            ->IsOffTheRecord();
     views::ImageView* icon = new views::ImageView();
     const gfx::Image& image = WebsiteSettingsUI::GetPermissionIcon(info);
     icon->SetImage(image.ToImageSkia());
     layout->AddView(icon, 1, 1, views::GridLayout::CENTER,
                     views::GridLayout::CENTER);
     layout->AddView(cookie_dialog_link_, 1, 1, views::GridLayout::CENTER,
                     views::GridLayout::CENTER);
     base::string16 comma = base::ASCIIToUTF16(", ");
 
     layout->AddView(new views::Label(comma + third_party_label_text), 1, 1,
@@ skipping 342 matching lines @@
 }
 
 void WebsiteSettingsPopupView::StyledLabelLinkClicked(views::StyledLabel* label,
                                                       const gfx::Range& range,
                                                       int event_flags) {
   presenter_->RecordWebsiteSettingsAction(
       WebsiteSettings::WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED);
   DevToolsWindow::OpenDevToolsWindow(web_contents_,
                                      DevToolsToggleAction::ShowSecurityPanel());
 }