chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm - Issue 1575623002: Disable Web Notifications in Incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Issue 1575623002: Disable Web Notifications in Incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permfix

Patch Set: No Profile* in WebsiteSettingsPopupView Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_selector_button_unittest.mm ('k') | chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm » ('j') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

index 7f32a38bd4cddfa31b685281604866288aa2baa7..a19897b49b37188a0ca666a17a4f8f5f5f313ee5 100644

--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

@@ -1355,6 +1355,8 @@ NSPoint AnchorPointForWindow(NSWindow* parent) {

WebsiteSettingsUI::PermissionInfo info;

info.type = CONTENT_SETTINGS_TYPE_COOKIES;

info.setting = CONTENT_SETTING_ALLOW;

+ // info.default_setting, info.source, and info.is_incognito have not been set,

+ // but GetPermissionIcon doesn't use any of those.

NSImage* image = WebsiteSettingsUI::GetPermissionIcon(info).ToNSImage();

NSImageView* imageView = [self addImageWithSize:[image size]

toView:cookiesView_