chrome/renderer/media/chrome_key_systems.cc - Issue 1575523002: Comparison and streaming operators for base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/media/chrome_key_systems.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/media/chrome_key_systems.cc

diff --git a/chrome/renderer/media/chrome_key_systems.cc b/chrome/renderer/media/chrome_key_systems.cc

index 5042cf14e26e6d9b6fbd4a2a4d678b4cc6e0d891..0a855299f95c5859b029c09c87a60f6e659efaf6 100644

--- a/chrome/renderer/media/chrome_key_systems.cc

+++ b/chrome/renderer/media/chrome_key_systems.cc

@@ -153,7 +153,7 @@ static void AddPepperBasedWidevine(

#if defined(WIDEVINE_CDM_MIN_GLIBC_VERSION)

Version glibc_version(gnu_get_libc_version());

DCHECK(glibc_version.IsValid());

- if (glibc_version.IsOlderThan(WIDEVINE_CDM_MIN_GLIBC_VERSION))

+ if (glibc_version < base::Version(WIDEVINE_CDM_MIN_GLIBC_VERSION))

return;

#endif // defined(WIDEVINE_CDM_MIN_GLIBC_VERSION)

« no previous file with comments | « chrome/installer/util/product_unittest.cc ('k') | components/component_updater/default_component_installer.cc » ('j') | no next file with comments »