chrome/installer/util/product_unittest.cc - Issue 1575523002: Comparison and streaming operators for base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/product_unittest.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/product_unittest.cc

diff --git a/chrome/installer/util/product_unittest.cc b/chrome/installer/util/product_unittest.cc

index 9eeba10e0f71bad6436d90f8b6348a4b0ac22985..82d89bb015956bd0f86e2fd8b48a172d034dc0b1 100644

--- a/chrome/installer/util/product_unittest.cc

+++ b/chrome/installer/util/product_unittest.cc

@@ -78,7 +78,7 @@ TEST(ProductTest, ProductInstallBasic) {

machine_state.GetProductState(system_level, distribution->GetType());

EXPECT_TRUE(chrome_state != NULL);

if (chrome_state != NULL) {

- EXPECT_TRUE(chrome_state->version().Equals(current_version));

+ EXPECT_EQ(chrome_state->version(), current_version);

EXPECT_FALSE(chrome_state->is_msi());

}

« no previous file with comments | « chrome/installer/util/installer_state_unittest.cc ('k') | chrome/renderer/media/chrome_key_systems.cc » ('j') | no next file with comments »