Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9793)

Unified Diff: chrome/installer/util/google_update_settings_unittest.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | chrome/installer/util/installer_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_update_settings_unittest.cc
diff --git a/chrome/installer/util/google_update_settings_unittest.cc b/chrome/installer/util/google_update_settings_unittest.cc
index 2f229ae84b723eeefae64b12ee557ddf4497a81a..6d411b62db6bd1e70e6c1ad1aab80b246843e5da 100644
--- a/chrome/installer/util/google_update_settings_unittest.cc
+++ b/chrome/installer/util/google_update_settings_unittest.cc
@@ -1097,9 +1097,9 @@ TEST_P(GetGoogleUpdateVersion, TestEmptyValue) {
TEST_P(GetGoogleUpdateVersion, TestRealValue) {
RegKey(root_key_, google_update::kRegPathGoogleUpdate, KEY_SET_VALUE)
.WriteValue(google_update::kRegGoogleUpdateVersion, kDummyVersion);
- Version expected(base::UTF16ToUTF8(kDummyVersion));
- EXPECT_TRUE(expected.Equals(
- GoogleUpdateSettings::GetGoogleUpdateVersion(system_install_)));
+ base::Version expected(base::UTF16ToUTF8(kDummyVersion));
+ EXPECT_EQ(expected,
+ GoogleUpdateSettings::GetGoogleUpdateVersion(system_install_));
// Make sure that there's no value in the other level (user or system).
EXPECT_FALSE(
GoogleUpdateSettings::GetGoogleUpdateVersion(!system_install_)
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | chrome/installer/util/installer_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698