chrome/installer/setup/install_worker.cc - Issue 1575523002: Comparison and streaming operators for base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install_worker.cc

diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc

index 5217bc9a462283f8cdbb44ae032772bfece0ffae..5878c00439e338b422250972c0fa50ccb7bf8aa1 100644

--- a/chrome/installer/setup/install_worker.cc

+++ b/chrome/installer/setup/install_worker.cc

@@ -365,7 +365,7 @@ void AddChromeWorkItems(const InstallationState& original_state,

// Note that we pass true for check_duplicates to avoid failing on in-use

// repair runs if the current_version is the same as the new_version.

bool check_for_duplicates = (current_version &&

- current_version->Equals(new_version));

+ *current_version == new_version);

install_list->AddMoveTreeWorkItem(

src_path.AppendASCII(new_version.GetString()).value(),

target_path.AppendASCII(new_version.GetString()).value(),

« no previous file with comments | « chrome/installer/setup/install.cc ('k') | chrome/installer/util/google_update_settings_unittest.cc » ('j') | no next file with comments »