chrome/app/chrome_crash_reporter_client.cc - Issue 1575523002: Comparison and streaming operators for base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_crash_reporter_client.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_crash_reporter_client.cc

diff --git a/chrome/app/chrome_crash_reporter_client.cc b/chrome/app/chrome_crash_reporter_client.cc

index 8c77d940343343bbcf30c514fec8e23329db3e16..576961f063c87a6d8525e68f3bb7763103dd0715 100644

--- a/chrome/app/chrome_crash_reporter_client.cc

+++ b/chrome/app/chrome_crash_reporter_client.cc

@@ -162,7 +162,7 @@ bool ChromeCrashReporterClient::GetDeferredUploadsSupported(

Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion(

!is_per_user_install);

if (!update_version.IsValid() ||

- update_version.IsOlderThan(std::string(kMinUpdateVersion)))

+ update_version < base::Version(kMinUpdateVersion))

return false;

return true;

« no previous file with comments | « base/version_unittest.cc ('k') | chrome/browser/component_updater/pnacl_component_installer.cc » ('j') | no next file with comments »