Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: chrome/app/chrome_crash_reporter_client.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/version_unittest.cc ('k') | chrome/browser/component_updater/pnacl_component_installer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_crash_reporter_client.h" 5 #include "chrome/app/chrome_crash_reporter_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/environment.h" 8 #include "base/environment.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 155
156 env->SetVar(env_vars::kShowRestart, "1"); 156 env->SetVar(env_vars::kShowRestart, "1");
157 return true; 157 return true;
158 } 158 }
159 159
160 bool ChromeCrashReporterClient::GetDeferredUploadsSupported( 160 bool ChromeCrashReporterClient::GetDeferredUploadsSupported(
161 bool is_per_user_install) { 161 bool is_per_user_install) {
162 Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion( 162 Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion(
163 !is_per_user_install); 163 !is_per_user_install);
164 if (!update_version.IsValid() || 164 if (!update_version.IsValid() ||
165 update_version.IsOlderThan(std::string(kMinUpdateVersion))) 165 update_version < base::Version(kMinUpdateVersion))
166 return false; 166 return false;
167 167
168 return true; 168 return true;
169 } 169 }
170 170
171 bool ChromeCrashReporterClient::GetIsPerUserInstall( 171 bool ChromeCrashReporterClient::GetIsPerUserInstall(
172 const base::FilePath& exe_path) { 172 const base::FilePath& exe_path) {
173 return InstallUtil::IsPerUserInstall(exe_path); 173 return InstallUtil::IsPerUserInstall(exe_path);
174 } 174 }
175 175
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 #endif 343 #endif
344 344
345 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 345 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
346 const std::string& process_type) { 346 const std::string& process_type) {
347 return process_type == switches::kRendererProcess || 347 return process_type == switches::kRendererProcess ||
348 process_type == switches::kPluginProcess || 348 process_type == switches::kPluginProcess ||
349 process_type == switches::kPpapiPluginProcess || 349 process_type == switches::kPpapiPluginProcess ||
350 process_type == switches::kZygoteProcess || 350 process_type == switches::kZygoteProcess ||
351 process_type == switches::kGpuProcess; 351 process_type == switches::kGpuProcess;
352 } 352 }
OLDNEW
« no previous file with comments | « base/version_unittest.cc ('k') | chrome/browser/component_updater/pnacl_component_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698