Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: components/component_updater/default_component_installer.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/component_updater/default_component_installer.cc
diff --git a/components/component_updater/default_component_installer.cc b/components/component_updater/default_component_installer.cc
index 9e3f34af777eeff1784c45f687c5343b54cd6a14..b33d3c6d2a036c4ca96bf826fbb16426ac3f4a0e 100644
--- a/components/component_updater/default_component_installer.cc
+++ b/components/component_updater/default_component_installer.cc
@@ -118,8 +118,9 @@ bool DefaultComponentInstaller::Install(const base::DictionaryValue& manifest,
bool DefaultComponentInstaller::GetInstalledFile(
const std::string& file,
base::FilePath* installed_file) {
- if (current_version_.Equals(base::Version(kNullVersion)))
+ if (current_version_ == base::Version(kNullVersion)) {
brettw 2016/01/08 19:31:16 Don't add {}
Rob Percival 2016/01/09 23:54:03 Done.
return false; // No component has been installed yet.
+ }
*installed_file = installer_traits_->GetBaseDirectory()
.AppendASCII(current_version_.GetString())

Powered by Google App Engine
This is Rietveld 408576698