Comparison and streaming operators for base::Version

components/component_updater/default_component_installer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/component_updater/default_component_installer.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 100 matching lines @@
   main_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&DefaultComponentInstaller::ComponentReady,
                  this, base::Passed(&manifest_copy)));
   return true;
 }
 
 bool DefaultComponentInstaller::GetInstalledFile(
     const std::string& file,
     base::FilePath* installed_file) {
-  if (current_version_.Equals(base::Version(kNullVersion)))
+  if (current_version_ == base::Version(kNullVersion)) {

[brettw, 2016/01/08 19:31:16]

Don't add {}

[Rob Percival, 2016/01/09 23:54:03]

Done.

     return false;  // No component has been installed yet.
+  }
 
   *installed_file = installer_traits_->GetBaseDirectory()
                         .AppendASCII(current_version_.GetString())
                         .AppendASCII(file);
   return true;
 }
 
 bool DefaultComponentInstaller::Uninstall() {
   DCHECK(thread_checker_.CalledOnValidThread());
   task_runner_->PostTask(
@@ skipping 135 matching lines @@
   ComponentReady(std::move(manifest_copy));
 }
 
 void DefaultComponentInstaller::ComponentReady(
     scoped_ptr<base::DictionaryValue> manifest) {
   installer_traits_->ComponentReady(current_version_, GetInstallDirectory(),
                                     std::move(manifest));
 }
 
 }  // namespace component_updater