[Sync] Simplify sync startup behavior.

components/browser_sync/browser/profile_sync_service.h

Index: components/browser_sync/browser/profile_sync_service.h
diff --git a/components/browser_sync/browser/profile_sync_service.h b/components/browser_sync/browser/profile_sync_service.h
index df981bc3e78339f174984afa2b44f2f65a1bddea..bb01193138e2d4cb296a7166aa75db412d0f3b81 100644
--- a/components/browser_sync/browser/profile_sync_service.h
+++ b/components/browser_sync/browser/profile_sync_service.h
@@ -508,9 +508,6 @@ class ProfileSyncService : public sync_driver::SyncService,
 
   SigninManagerBase* signin() const;
 
-  // Used by tests.
-  bool auto_start_enabled() const;
-
   SyncErrorController* sync_error_controller() {
     return sync_error_controller_.get();
   }
@@ -782,6 +779,9 @@ class ProfileSyncService : public sync_driver::SyncService,
   // Restarts sync clearing directory in the process.
   void OnClearServerDataDone();
 
+  // True if setup has been completed at least once and is not in progress.
+  bool IsSetupComplete() const;

[Nicolas Zea, 2016/02/29 21:21:55]

I wonder if there's a better way of distinguishing this from
IsFirstSetupComplete. I think they're too similar in name right now.

Effectively this is controlling whether we can kick off configuration right.
Maybe CanStartConfigure? 

[maxbogue, 2016/03/09 02:00:59]

Changed to CanConfigureDatatypes; that sound good?

+
   // This profile's SyncClient, which abstracts away non-Sync dependencies and
   // the Sync API component factory.
   scoped_ptr<sync_driver::SyncClient> sync_client_;