[Sync] Simplify sync startup behavior.

components/browser_sync/browser/profile_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
 #define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
 
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 136 matching lines @@
 //    * GetActiveDataTypes()
 //    * IsUsingSecondaryPassphrase()
 //    * IsEncryptEverythingEnabled()
 //    * IsPassphraseRequired()/IsPassphraseRequiredForDecryption()
 //
 //   The "sync everything" state cannot be read from ProfileSyncService, but
 //   is instead pulled from SyncPrefs.HasKeepEverythingSynced().
 //
 // Initial sync setup:
 //
 //   For privacy reasons, it is usually desirable to avoid syncing any data

[Nicolas Zea, 2016/02/29 21:21:55]

Maybe update this comment to mention IsSetupComplete?

[maxbogue, 2016/03/09 02:00:59]

Done, PTAL.

 //   types until the user has finished setting up sync. There are two APIs
 //   that control the initial sync download:
 //
 //    * SetFirstSetupComplete()
 //    * SetSetupInProgress()
 //
 //   SetFirstSetupComplete() should be called once the user has finished setting
 //   up sync at least once on their account. SetSetupInProgress(true) should be
 //   called while the user is actively configuring their account, and then
 //   SetSetupInProgress(false) should be called when configuration is complete.
@@ skipping 333 matching lines @@
   virtual bool IsEncryptEverythingAllowed() const;
 
   // Sets whether encrypting all the sync data is allowed or not.
   virtual void SetEncryptEverythingAllowed(bool allowed);
 
   // Returns true if the syncer is waiting for new datatypes to be encrypted.
   virtual bool encryption_pending() const;
 
   SigninManagerBase* signin() const;
 
-  // Used by tests.
-  bool auto_start_enabled() const;
-
   SyncErrorController* sync_error_controller() {
     return sync_error_controller_.get();
   }
 
   // TODO(sync): This is only used in tests.  Can we remove it?
   const sync_driver::DataTypeStatusTable& data_type_status_table() const;
 
   sync_driver::DataTypeManager::ConfigureStatus configure_status() {
     return configure_status_;
   }
@@ skipping 251 matching lines @@
 
   // Calls data type manager to start catch up configure.
   void BeginConfigureCatchUpBeforeClear();
 
   // Calls sync backend to send ClearServerDataMessage to server.
   void ClearAndRestartSyncForPassphraseEncryption();
 
   // Restarts sync clearing directory in the process.
   void OnClearServerDataDone();
 
+  // True if setup has been completed at least once and is not in progress.
+  bool IsSetupComplete() const;

[Nicolas Zea, 2016/02/29 21:21:55]

I wonder if there's a better way of distinguishing this from
IsFirstSetupComplete. I think they're too similar in name right now.

Effectively this is controlling whether we can kick off configuration right.
Maybe CanStartConfigure? 

[maxbogue, 2016/03/09 02:00:59]

Changed to CanConfigureDatatypes; that sound good?

+
   // This profile's SyncClient, which abstracts away non-Sync dependencies and
   // the Sync API component factory.
   scoped_ptr<sync_driver::SyncClient> sync_client_;
 
   // The class that handles getting, setting, and persisting sync
   // preferences.
   sync_driver::SyncPrefs sync_prefs_;
 
   // TODO(ncarter): Put this in a profile, once there is UI for it.
   // This specifies where to find the sync server.
@@ skipping 199 matching lines @@
   base::WeakPtrFactory<ProfileSyncService> startup_controller_weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(
     const syncer::SyncProtocolError& error);
 
 
 #endif  // COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_