Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1575093002: Reland of Add guards to GrTextureProvider (Closed)

Created:
4 years, 11 months ago by joshualitt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gpudeviceguards
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Add guards to GrTextureProvider (patchset #1 id:1 of https://codereview.chromium.org/1565313003/ ) Reason for revert: should be fixed Original issue's description: > Revert of Add guards to GrTextureProvider (patchset #5 id:80001 of https://codereview.chromium.org/1567983002/ ) > > Reason for revert: > breaking asan bot > > Original issue's description: > > Add guards to GrTextureProvider > > > > TBR=bsalomon@google.com > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1567983002 > > > > Committed: https://skia.googlesource.com/skia/+/b30dd1db1d914b85a691b4724713ba1b0f16cd6c > > TBR=robertphillips@google.com,joshualitt@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/9a9515e081c54efdd5a0b0 f662c013cbeef6d63f TBR=bsalomon@google.com TBR=robertphillips@google.com,joshualitt@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/6d0872d9bd97de5301214a258e141dd5fbeecffc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -16 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrTextureProvider.h View 4 chunks +7 lines, -10 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrResourceProvider.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTextureProvider.cpp View 7 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
joshualitt
Created Reland of Add guards to GrTextureProvider
4 years, 11 months ago (2016-01-11 16:04:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575093002/1
4 years, 11 months ago (2016-01-11 16:04:47 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/5209)
4 years, 11 months ago (2016-01-11 16:05:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575093002/1
4 years, 11 months ago (2016-01-11 16:08:47 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 16:27:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6d0872d9bd97de5301214a258e141dd5fbeecffc

Powered by Google App Engine
This is Rietveld 408576698