Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1574913003: Defer widget updates in ContainerNode::parserRemoveChild. (Closed)

Created:
4 years, 11 months ago by Oliver Chang
Modified:
4 years, 11 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Defer widget updates in ContainerNode::parserRemoveChild. ContainerNode::parserRemoveChild is the only consumer of ContainerNode::removeBetween that doesn't defer widget updates during the call. This could potentially lead to problems with scripts running at an inopportune time. This patch adds a RAII guard that runs deferred widget updates at the end of parserRemoveChild. TBR=kouhei@chromium.org BUG=560011 Review URL: https://codereview.chromium.org/1464223002 Cr-Commit-Position: refs/heads/master@{#363154} (cherry picked from commit 05926d6f4e749cd49a16fa04a35e3498eb1b01a0) Committed: https://chromium.googlesource.com/chromium/src/+/ca5ef94e715de68255be76e3d9a9bd4b57ac1ff3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Oliver Chang
4 years, 11 months ago (2016-01-11 18:30:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca5ef94e715de68255be76e3d9a9bd4b57ac1ff3.

Powered by Google App Engine
This is Rietveld 408576698