Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1574683002: Include addBool/BoolReader into FlatBuffers. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include addBool/BoolReader into FlatBuffers. This should simplify the code generated for summary builders/readers. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/10adc73dab85b910df42793c947d9c3c68e6ebc2

Patch Set 1 #

Patch Set 2 : Remove debug output. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -11 lines) Patch
M pkg/analyzer/lib/src/summary/flat_buffers.dart View 5 chunks +33 lines, -3 lines 2 comments Download
M pkg/analyzer/test/src/summary/flat_buffers_test.dart View 1 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 11 months ago (2016-01-09 05:33:22 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1574683002/diff/20001/pkg/analyzer/lib/src/summary/flat_buffers.dart File pkg/analyzer/lib/src/summary/flat_buffers.dart (right): https://codereview.chromium.org/1574683002/diff/20001/pkg/analyzer/lib/src/summary/flat_buffers.dart#newcode22 pkg/analyzer/lib/src/summary/flat_buffers.dart:22: bool read(BufferPointer bp) => bp._getInt8() == 1; Nit: ...
4 years, 11 months ago (2016-01-09 14:38:46 UTC) #2
scheglov
https://codereview.chromium.org/1574683002/diff/20001/pkg/analyzer/lib/src/summary/flat_buffers.dart File pkg/analyzer/lib/src/summary/flat_buffers.dart (right): https://codereview.chromium.org/1574683002/diff/20001/pkg/analyzer/lib/src/summary/flat_buffers.dart#newcode22 pkg/analyzer/lib/src/summary/flat_buffers.dart:22: bool read(BufferPointer bp) => bp._getInt8() == 1; On 2016/01/09 ...
4 years, 11 months ago (2016-01-09 18:26:14 UTC) #3
scheglov
4 years, 11 months ago (2016-01-09 18:26:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
10adc73dab85b910df42793c947d9c3c68e6ebc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698