Include addBool/BoolReader into FlatBuffers.

pkg/analyzer/lib/src/summary/flat_buffers.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.summary.flat_buffers;
 
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:math';
 import 'dart:typed_data';
 
 /**
+ * The reader of booleans.
+ */
+class BoolReader extends Reader<bool> {
+  const BoolReader() : super();
+
+  @override
+  int get size => 1;
+
+  @override
+  bool read(BufferPointer bp) => bp._getInt8() == 1;

[Paul Berry, 2016/01/09 14:38:46]

Nit: I'd prefer to do `bp._getInt8() != 0`, for consistency with the way bools
are handled in languages like C.  Of course it will never actually make a
difference assuming the summary isn't corrupted :)

[scheglov, 2016/01/09 18:26:14]

Done.

+}
+
+/**
  * A pointer to some data.
  */
 class BufferPointer {
   final ByteData _buffer;
   final int _offset;
 
   factory BufferPointer.fromBytes(List<int> byteList, [int offset = 0]) {
     Uint8List uint8List = _asUint8List(byteList);
     ByteData buf = new ByteData.view(uint8List.buffer);
     return new BufferPointer._(buf, uint8List.offsetInBytes + offset);
@@ skipping 72 matching lines @@
    */
   int _currentTableEndTail;
 
   _VTable _currentVTable;
 
   Builder({this.initialSize: 1024}) {
     reset();
   }
 
   /**
+   * Add the [field] with the given boolean [value].  The field is not added if
+   * the [value] is equal to [def].  Booleans are stored as 8-bit fields with
+   * `0` for `false` and `1` for `true`.
+   */
+  void addBool(int field, bool value, [bool def]) {
+    if (_currentVTable == null) {
+      throw new StateError('Start a table before adding values.');
+    }
+    if (value != null && value != def) {
+      int size = 1;
+      _prepare(size, 1);
+      _trackField(field);
+      _buf.setInt8(_buf.lengthInBytes - _tail, value ? 1 : 0);
+    }
+  }
+
+  /**
    * Add the [field] with the given 32-bit signed integer [value].  The field is
    * not added if the [value] is equal to [def].
    */
   void addInt32(int field, int value, [int def]) {
     if (_currentVTable == null) {
       throw new StateError('Start a table before adding values.');
     }
-    if (value != def) {
+    if (value != null && value != def) {
       int size = 4;
       _prepare(size, 1);
       _trackField(field);
       _setInt32AtTail(_buf, _tail, value);
     }
   }
 
   /**
    * Add the [field] with the given 64-bit signed integer [value].  The field is
    * not added if the [value] is equal to [def].
    */
   void addInt64(int field, int value, [int def]) {
     if (_currentVTable == null) {
       throw new StateError('Start a table before adding values.');
     }
-    if (value != def) {
+    if (value != null && value != def) {
       int size = 8;
       _prepare(size, 1);
       _trackField(field);
       _setInt64AtTail(_buf, _tail, value);
     }
   }
 
   /**
    * Add the [field] with the given 8-bit signed integer [value].  The field is
    * not added if the [value] is equal to [def].
    */
   void addInt8(int field, int value, [int def]) {
     if (_currentVTable == null) {
       throw new StateError('Start a table before adding values.');
     }
-    if (value != def) {
+    if (value != null && value != def) {
       int size = 1;
       _prepare(size, 1);
       _trackField(field);
       _buf.setInt8(_buf.lengthInBytes - _tail, value);
     }
   }
 
   /**
    * Add the [field] referencing an object with the given [offset].
    */
@@ skipping 473 matching lines @@
     // Table size.
     buf.setUint16(bufOffset, tableSize, Endianness.LITTLE_ENDIAN);
     bufOffset += 2;
     // Field offsets.
     for (int fieldOffset in fieldOffsets) {
       buf.setUint16(bufOffset, fieldOffset, Endianness.LITTLE_ENDIAN);
       bufOffset += 2;
     }
   }
 }