net/quic/crypto/quic_crypto_server_config.cc - Issue 1574633002: relnote: Re-enable strike register lookups for QUIC replay protection, until at least QUIC_VERSION_…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/quic_crypto_server_config.cc

Issue 1574633002: relnote: Re-enable strike register lookups for QUIC replay protection, until at least QUIC_VERSION_… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@07_CL_111570157

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/crypto/quic_crypto_server_config.cc

diff --git a/net/quic/crypto/quic_crypto_server_config.cc b/net/quic/crypto/quic_crypto_server_config.cc

index c7b83bfb9b1305049f9f2cc1abe1c2b6d8702ba8..fc17b739309fd974adb8f7002d34a175de701f08 100644

--- a/net/quic/crypto/quic_crypto_server_config.cc

+++ b/net/quic/crypto/quic_crypto_server_config.cc

@@ -1090,8 +1090,8 @@ void QuicCryptoServerConfig::EvaluateClientHello(

// Server nonce is optional, and used for key derivation if present.

client_hello.GetStringPiece(kServerNonceTag, &info->server_nonce);

- if (version > QUIC_VERSION_26) {

- DVLOG(1) << "No 0-RTT replay protection in QUIC_VERSION_27 and higher.";

+ if (version > QUIC_VERSION_30) {

+ DVLOG(1) << "No 0-RTT replay protection in QUIC_VERSION_31 and higher.";

// If the server nonce is empty and we're requiring handshake confirmation

// for DoS reasons then we must reject the CHLO.

if (FLAGS_quic_require_handshake_confirmation &&

« no previous file with comments | « net/quic/crypto/crypto_server_test.cc ('k') | net/quic/quic_crypto_server_stream_test.cc » ('j') | no next file with comments »