Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: net/quic/crypto/quic_crypto_server_config.cc

Issue 1574633002: relnote: Re-enable strike register lookups for QUIC replay protection, until at least QUIC_VERSION_… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@07_CL_111570157
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/crypto/crypto_server_test.cc ('k') | net/quic/quic_crypto_server_stream_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/crypto/quic_crypto_server_config.h" 5 #include "net/quic/crypto/quic_crypto_server_config.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 1072 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 if (FLAGS_use_early_return_when_verifying_chlo) { 1083 if (FLAGS_use_early_return_when_verifying_chlo) {
1084 helper.ValidationComplete(QUIC_NO_ERROR, ""); 1084 helper.ValidationComplete(QUIC_NO_ERROR, "");
1085 return; 1085 return;
1086 } 1086 }
1087 found_error = true; 1087 found_error = true;
1088 } 1088 }
1089 1089
1090 // Server nonce is optional, and used for key derivation if present. 1090 // Server nonce is optional, and used for key derivation if present.
1091 client_hello.GetStringPiece(kServerNonceTag, &info->server_nonce); 1091 client_hello.GetStringPiece(kServerNonceTag, &info->server_nonce);
1092 1092
1093 if (version > QUIC_VERSION_26) { 1093 if (version > QUIC_VERSION_30) {
1094 DVLOG(1) << "No 0-RTT replay protection in QUIC_VERSION_27 and higher."; 1094 DVLOG(1) << "No 0-RTT replay protection in QUIC_VERSION_31 and higher.";
1095 // If the server nonce is empty and we're requiring handshake confirmation 1095 // If the server nonce is empty and we're requiring handshake confirmation
1096 // for DoS reasons then we must reject the CHLO. 1096 // for DoS reasons then we must reject the CHLO.
1097 if (FLAGS_quic_require_handshake_confirmation && 1097 if (FLAGS_quic_require_handshake_confirmation &&
1098 info->server_nonce.empty()) { 1098 info->server_nonce.empty()) {
1099 info->reject_reasons.push_back(SERVER_NONCE_REQUIRED_FAILURE); 1099 info->reject_reasons.push_back(SERVER_NONCE_REQUIRED_FAILURE);
1100 } 1100 }
1101 helper.ValidationComplete(QUIC_NO_ERROR, ""); 1101 helper.ValidationComplete(QUIC_NO_ERROR, "");
1102 return; 1102 return;
1103 } 1103 }
1104 1104
(...skipping 688 matching lines...) Expand 10 before | Expand all | Expand 10 after
1793 is_primary(false), 1793 is_primary(false),
1794 primary_time(QuicWallTime::Zero()), 1794 primary_time(QuicWallTime::Zero()),
1795 priority(0), 1795 priority(0),
1796 source_address_token_boxer(nullptr) {} 1796 source_address_token_boxer(nullptr) {}
1797 1797
1798 QuicCryptoServerConfig::Config::~Config() { 1798 QuicCryptoServerConfig::Config::~Config() {
1799 STLDeleteElements(&key_exchanges); 1799 STLDeleteElements(&key_exchanges);
1800 } 1800 }
1801 1801
1802 } // namespace net 1802 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/crypto/crypto_server_test.cc ('k') | net/quic/quic_crypto_server_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698