ui/gfx/render_text_unittest.cc - Issue 15746013: Fix cursor positioning regression from r201136. GetCursorPos() shouldn't assume

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_unittest.cc

Issue 15746013: Fix cursor positioning regression from r201136. GetCursorPos() shouldn't assume (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_unittest.cc

===================================================================

--- ui/gfx/render_text_unittest.cc (revision 201137)

+++ ui/gfx/render_text_unittest.cc (working copy)

@@ -285,11 +285,8 @@

}

// GetGlyphBounds() should yield the entire string bounds for text index 0.

- int height = 0;

- ui::Range bounds;

- render_text->GetGlyphBounds(0U, &bounds, &height);

EXPECT_EQ(render_text->GetStringSize().width(),

- static_cast<int>(bounds.length()));

+ static_cast<int>(render_text->GetGlyphBounds(0U).length()));

// Cursoring is independent of underlying characters when text is obscured.

const wchar_t* const texts[] = {

« no previous file with comments | « ui/gfx/render_text_mac.cc ('k') | ui/gfx/render_text_win.h » ('j') | no next file with comments »