ui/gfx/render_text_win.h - Issue 15746013: Fix cursor positioning regression from r201136. GetCursorPos() shouldn't assume

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_win.h

Issue 15746013: Fix cursor positioning regression from r201136. GetCursorPos() shouldn't assume (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_win.h

===================================================================

--- ui/gfx/render_text_win.h (revision 201137)

+++ ui/gfx/render_text_win.h (working copy)

@@ -80,9 +80,7 @@

const SelectionModel& selection,

VisualCursorDirection direction) OVERRIDE;

virtual void SetSelectionModel(const SelectionModel& model) OVERRIDE;

- virtual void GetGlyphBounds(size_t index,

- ui::Range* xspan,

- int* height) OVERRIDE;

+ virtual ui::Range GetGlyphBounds(size_t index) OVERRIDE;

virtual std::vector<Rect> GetSubstringBounds(const ui::Range& range) OVERRIDE;

virtual size_t TextIndexToLayoutIndex(size_t index) const OVERRIDE;

virtual size_t LayoutIndexToTextIndex(size_t index) const OVERRIDE;

« no previous file with comments | « ui/gfx/render_text_unittest.cc ('k') | ui/gfx/render_text_win.cc » ('j') | no next file with comments »