Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1574543002: Faster YUV conversion in WebrtcVideoCapturerAdapter. (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Faster YUV conversion in WebrtcVideoCapturerAdapter. WebrtcVideoCapturerAdapter was previously relying on cricket::VideoCapturer for YUV conversion, which was also resizing the frames, but that's not desired. Now it's responsible for YUV conversion, which also allows to optimize it by coverting only parts of the screen that are changing. Also fixed WebrtcVideoCapturerAdapter to avoid multiple simultaneous capture requests, which was causing assert failure in DesktopCapturer. BUG=547158 Committed: https://crrev.com/5b105ebfe8dc4a5e11bfa8fe56aa3f544eeae902 Cr-Commit-Position: refs/heads/master@{#368508}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -73 lines) Patch
M remoting/host/cast_extension_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/webrtc_video_capturer_adapter.h View 3 chunks +19 lines, -12 lines 0 comments Download
M remoting/protocol/webrtc_video_capturer_adapter.cc View 1 2 6 chunks +81 lines, -59 lines 0 comments Download
M remoting/remoting.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sergey Ulanov
Moved half of https://codereview.chromium.org/1571543002/
4 years, 11 months ago (2016-01-08 19:36:21 UTC) #3
Jamie
lgtm https://codereview.chromium.org/1574543002/diff/20001/remoting/protocol/webrtc_video_capturer_adapter.cc File remoting/protocol/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/1574543002/diff/20001/remoting/protocol/webrtc_video_capturer_adapter.cc#newcode182 remoting/protocol/webrtc_video_capturer_adapter.cc:182: int left = i.rect().left(); Nit: Unnecessary extra space ...
4 years, 11 months ago (2016-01-08 23:33:53 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/1574543002/diff/20001/remoting/protocol/webrtc_video_capturer_adapter.cc File remoting/protocol/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/1574543002/diff/20001/remoting/protocol/webrtc_video_capturer_adapter.cc#newcode182 remoting/protocol/webrtc_video_capturer_adapter.cc:182: int left = i.rect().left(); On 2016/01/08 23:33:52, Jamie wrote: ...
4 years, 11 months ago (2016-01-09 01:33:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574543002/40001
4 years, 11 months ago (2016-01-09 01:34:43 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-09 02:11:55 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-09 02:12:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b105ebfe8dc4a5e11bfa8fe56aa3f544eeae902
Cr-Commit-Position: refs/heads/master@{#368508}

Powered by Google App Engine
This is Rietveld 408576698