Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1574353003: Update ChromiumPacketSocket factory to apply PacketOptions it receives. (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@packet_options
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ChromiumPacketSocket factory to apply PacketOptions it receives. In Chromium libjingle is compiled with ENABLED_EXTERNAL_AUTH. This means that the sending PacketSocketFactory is responsible for updating send time in the outgoing RTP packets and calculating HMAC. ChromiumPacketSocket previously wasn't doing that, so the receiver could not validate the RTP packets. BUG=547158 Committed: https://crrev.com/8cf7497b319ee3b7c0fe6449790c13d78a8b61e5 Cr-Commit-Position: refs/heads/master@{#369885}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M remoting/protocol/chromium_socket_factory.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Sergey Ulanov
This change depends on https://codereview.chromium.org/1578323002/ and https://codereview.chromium.org/1577123004/
4 years, 11 months ago (2016-01-12 19:32:32 UTC) #2
Jamie
LGTM, but I think there are some errors in the CL description: s/Thins/This/ s/could validate/could ...
4 years, 11 months ago (2016-01-12 22:08:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574353003/20001
4 years, 11 months ago (2016-01-15 23:43:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-16 00:07:40 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 00:08:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cf7497b319ee3b7c0fe6449790c13d78a8b61e5
Cr-Commit-Position: refs/heads/master@{#369885}

Powered by Google App Engine
This is Rietveld 408576698