Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1577123004: Use rtppacketutil.h in socket_host*.cc (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 11 months ago
Reviewers:
pthatcher2, pthatcher1
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use rtputils.h in socket_host*.cc Previously socket_host.cc contained the code that's used to update RTP header in outgoing packets. It was moved to rtputils.cc in WebRTC. This CL removes it from socket_host.cc. BUG=547158 Committed: https://crrev.com/d446934dfd458b7492414ace4c75947eb60d079e Cr-Commit-Position: refs/heads/master@{#369863}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -847 lines) Patch
M content/browser/renderer_host/p2p/socket_host.h View 1 chunk +0 lines, -27 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host.cc View 1 3 chunks +8 lines, -422 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 3 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
D content/browser/renderer_host/p2p/socket_host_unittest.cc View 1 chunk +0 lines, -386 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Sergey Ulanov
Chromium change corresponding to https://codereview.chromium.org/1578323002/. Will need to be landed once that webrtc change is ...
4 years, 11 months ago (2016-01-12 19:20:26 UTC) #2
Sergey Ulanov
pthatcher: ping
4 years, 11 months ago (2016-01-14 20:21:16 UTC) #3
pthatcher1
lgtm Except, can you update the description to be rtputils instead of rtppacketutils?
4 years, 11 months ago (2016-01-14 21:01:18 UTC) #5
Sergey Ulanov
On 2016/01/14 21:01:18, pthatcher1 wrote: > lgtm > > Except, can you update the description ...
4 years, 11 months ago (2016-01-15 21:12:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577123004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577123004/40001
4 years, 11 months ago (2016-01-15 21:14:38 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-15 22:20:30 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 22:22:39 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d446934dfd458b7492414ace4c75947eb60d079e
Cr-Commit-Position: refs/heads/master@{#369863}

Powered by Google App Engine
This is Rietveld 408576698