Unify and Improve the Sign-In and Sync Confirmation Screens on Clank.

chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
index 3cccd6cbfd8b0ad235ac16cebd699650a3827e0d..e988f9c4ddd0d3d9987cd5b5a889025d7de6f521 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
@@ -37,6 +37,7 @@ public class SigninPromoScreen
         extends AlwaysDismissedDialog implements AccountFirstRunView.Listener {
     private AccountFirstRunView mAccountFirstRunView;
     private ProfileDataCache mProfileDataCache;
+    private String mAccountName;
 
     /**
      * Launches the signin promo if it needs to be displayed.
@@ -99,15 +100,25 @@ public class SigninPromoScreen
         mProfileDataCache.destroy();
         mProfileDataCache = null;
     }
+    @Override
+    public void onAccountSelectionCanceled() {
+        SigninPromoUma.recordAction(SigninPromoUma.SIGNIN_PROMO_DECLINED);
+        dismiss();
+    }
 
     @Override
-    public void onAccountSelectionConfirmed(String accountName) {
+    public void onNewAccount() {
+        AccountAdder.getInstance().addAccount(getOwnerActivity(), AccountAdder.ADD_ACCOUNT_RESULT);
+    }
+
+    @Override
+    public void onAccountSelected(String accountName) {
+        mAccountName = accountName;
         final Account account =
                 AccountManagerHelper.get(getContext()).getAccountFromName(accountName);
         SignInFlowObserver signInCallback = new SignInFlowObserver() {
             @Override
             public void onSigninComplete() {
-                mAccountFirstRunView.switchToSignedMode();
                 SigninManager.get(getOwnerActivity()).logInSignedInUser();
                 SigninPromoUma.recordAction(SigninPromoUma.SIGNIN_PROMO_ACCEPTED);
                 RecordUserAction.record("Signin_Signin_Succeed");
@@ -126,28 +137,17 @@ public class SigninPromoScreen
     }
 
     @Override
-    public void onAccountSelectionCanceled() {
-        SigninPromoUma.recordAction(SigninPromoUma.SIGNIN_PROMO_DECLINED);
-        dismiss();
-    }
-
-    @Override
-    public void onNewAccount() {
-        AccountAdder.getInstance().addAccount(getOwnerActivity(), AccountAdder.ADD_ACCOUNT_RESULT);
-    }
-
-    @Override
-    public void onSigningInCompleted(String accountName) {
+    public void onDoneClicked() {
         dismiss();
     }
 
     @Override
-    public void onSettingsButtonClicked(String accountName) {
+    public void onSettingsClicked() {
         if (ProfileSyncService.get() != null) {
             Intent intent = PreferencesLauncher.createIntentForSettingsPage(getContext(),
                     SyncCustomizationFragment.class.getName());
             Bundle args = new Bundle();
-            args.putString(SyncCustomizationFragment.ARGUMENT_ACCOUNT, accountName);
+            args.putString(SyncCustomizationFragment.ARGUMENT_ACCOUNT, mAccountName);
             intent.putExtra(Preferences.EXTRA_SHOW_FRAGMENT_ARGUMENTS, args);
             getContext().startActivity(intent);
         }