chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java - Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java » ('j') | chrome/browser/android/profiles/profile_downloader_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

index 2b70b6356cebf7072807ff30890dad186f962ed4..3da4ec612965f5766e4e9d3a5fadffde275bd51d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

@@ -603,6 +603,12 @@ public class RecentTabsRowAdapter extends BaseExpandableListAdapter {

public void onNewAccount() {

RecordUserAction.record("Signin_AddAccountToDevice");

}

+ @Override

+ public void onAccountSelectionCancelled() {

+ RecordUserAction.record("Signin_Cancel_FromRecentTabs");

newt (away) 2016/02/09 23:08:12 also need to add this actions.xml

PEConn 2016/02/11 14:44:56 Removed to put in a different CL.

+ mRecentTabsManager.setSigninPromoDeclined();

+ notifyDataSetChanged();

+ }

});

}

if (!mRecentTabsManager.isSignedIn()) {